Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 23440035: Diagnostic code for chromium 284577 (Closed)

Created:
7 years, 3 months ago by mvstanton
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Every place where AllocationMemento is initialized with an AllocationSite is now checked to be sure a valid Site goes in. This is temporary code to diagnose chromium bug 284577. (This is a second attempt, the first attempt ran into the problem of undefined ordering of function calls in Windows and Mac optimized builds, see the fixes in code-stubs-hydrogen.cc). BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +25 lines, -20 lines 0 comments Download
M src/heap.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-13 13:47:55 UTC) #1
mvstanton
7 years, 3 months ago (2013-09-13 13:50:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r16719 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698