Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23440033: Move FileAPI test code from webkit to content (Closed)

Created:
7 years, 3 months ago by kinuko
Modified:
7 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, vandebo (ex-Chrome), jam, nkostylev+watch_chromium.org, Lei Zhang, tfarina, Greg Billock, dcheng, joi+watch-content_chromium.org, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, nhiroki+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move FileAPI test code from webkit to content (Namespace fix will come later) BUG=265769 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226399

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -10894 lines) Patch
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
A + content/browser/fileapi/blob_url_request_job_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
A + content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/fileapi/dragged_file_util_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_system_context_unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
A + content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/fileapi/file_system_operation_runner_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_system_quota_client_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/fileapi/file_writer_delegate_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/local_file_util_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/transient_file_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 4 chunks +30 lines, -28 lines 0 comments Download
A + content/public/test/sandbox_file_system_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/test/sandbox_file_system_test_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/test/test_file_system_backend.h View 1 4 chunks +4 lines, -6 lines 0 comments Download
A + content/public/test/test_file_system_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/test_file_system_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/test/test_file_system_context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/public/test/test_file_system_options.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/test/test_file_system_options.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/browser/blob/blob_url_request_job_unittest.cc View 1 2 1 chunk +0 lines, -433 lines 0 comments Download
D webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 1 chunk +0 lines, -326 lines 0 comments Download
D webkit/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 1 chunk +0 lines, -806 lines 0 comments Download
D webkit/browser/fileapi/dragged_file_util_unittest.cc View 1 2 1 chunk +0 lines, -545 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D webkit/browser/fileapi/file_system_context_unittest.cc View 1 2 1 chunk +0 lines, -327 lines 0 comments Download
D webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 2 1 chunk +0 lines, -319 lines 0 comments Download
D webkit/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 2 1 chunk +0 lines, -266 lines 0 comments Download
D webkit/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 1 chunk +0 lines, -1241 lines 0 comments Download
D webkit/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 2 1 chunk +0 lines, -328 lines 0 comments Download
D webkit/browser/fileapi/file_system_operation_runner_unittest.cc View 1 1 chunk +0 lines, -162 lines 0 comments Download
D webkit/browser/fileapi/file_system_quota_client_unittest.cc View 1 1 chunk +0 lines, -561 lines 0 comments Download
D webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 1 2 1 chunk +0 lines, -363 lines 0 comments Download
D webkit/browser/fileapi/file_writer_delegate_unittest.cc View 1 2 1 chunk +0 lines, -453 lines 0 comments Download
D webkit/browser/fileapi/local_file_util_unittest.cc View 1 1 chunk +0 lines, -388 lines 0 comments Download
D webkit/browser/fileapi/mock_file_system_context.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/browser/fileapi/mock_file_system_context.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D webkit/browser/fileapi/mock_file_system_options.h View 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/browser/fileapi/mock_file_system_options.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 1 chunk +0 lines, -2438 lines 0 comments Download
D webkit/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 2 1 chunk +0 lines, -280 lines 0 comments Download
D webkit/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 1 chunk +0 lines, -325 lines 0 comments Download
D webkit/browser/fileapi/sandbox_file_system_test_helper.h View 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/browser/fileapi/sandbox_file_system_test_helper.cc View 1 1 chunk +0 lines, -152 lines 0 comments Download
D webkit/browser/fileapi/test_file_system_backend.h View 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/browser/fileapi/test_file_system_backend.cc View 1 chunk +0 lines, -247 lines 0 comments Download
D webkit/browser/fileapi/transient_file_util_unittest.cc View 1 1 chunk +0 lines, -122 lines 0 comments Download
D webkit/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 2 1 chunk +0 lines, -277 lines 0 comments Download
M webkit/storage_browser.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
John, can you review this?
7 years, 3 months ago (2013-09-18 08:22:10 UTC) #1
jam
lgtm
7 years, 3 months ago (2013-09-19 06:32:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23440033/114001
7 years, 2 months ago (2013-10-01 23:45:03 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 00:47:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23440033/114001
7 years, 2 months ago (2013-10-02 01:06:36 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 01:54:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23440033/114001
7 years, 2 months ago (2013-10-02 03:35:01 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 06:43:13 UTC) #8
Message was sent while issue was closed. 
Change committed as 226399

Powered by Google App Engine
This is Rietveld 408576698