Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2344003002: Adding a confirmation dialog for It2Me on Mac (Closed)

Created:
4 years, 3 months ago by joedow
Modified:
4 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a confirmation dialog for It2Me on Mac This change adds a confirmation dialog for the It2Me Mac host. This dialog will be displayed when an incoming It2Me connection and will wait up to 60 seconds for the user to accept/reject it. If the user accepts the connection then we will complete the conneciton process, otherwise the incoming request will be rejected. BUG=645540 Committed: https://crrev.com/873700139f1834cd79da404cc4ceeb5c264b7703 Cr-Commit-Position: refs/heads/master@{#419676}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Renaming dialog controller callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -15 lines) Patch
M remoting/host/it2me/BUILD.gn View 3 chunks +12 lines, -1 line 0 comments Download
D remoting/host/it2me/it2me_confirmation_dialog_mac.cc View 1 chunk +0 lines, -14 lines 0 comments Download
A remoting/host/it2me/it2me_confirmation_dialog_mac.mm View 1 1 chunk +190 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (13 generated)
joedow
PTAL!
4 years, 3 months ago (2016-09-15 23:06:09 UTC) #6
Sergey Ulanov
https://codereview.chromium.org/2344003002/diff/1/remoting/host/it2me/it2me_confirmation_dialog_mac.mm File remoting/host/it2me/it2me_confirmation_dialog_mac.mm (right): https://codereview.chromium.org/2344003002/diff/1/remoting/host/it2me/it2me_confirmation_dialog_mac.mm#newcode63 remoting/host/it2me/it2me_confirmation_dialog_mac.mm:63: ResultCallback result_callback_; result_callback_ is stored here and also in ...
4 years, 3 months ago (2016-09-15 23:48:42 UTC) #7
joedow
Addressed feedback, PTAL! https://codereview.chromium.org/2344003002/diff/1/remoting/host/it2me/it2me_confirmation_dialog_mac.mm File remoting/host/it2me/it2me_confirmation_dialog_mac.mm (right): https://codereview.chromium.org/2344003002/diff/1/remoting/host/it2me/it2me_confirmation_dialog_mac.mm#newcode63 remoting/host/it2me/it2me_confirmation_dialog_mac.mm:63: ResultCallback result_callback_; On 2016/09/15 23:48:41, Sergey ...
4 years, 3 months ago (2016-09-16 00:23:00 UTC) #10
joedow
Ping!
4 years, 3 months ago (2016-09-19 17:03:00 UTC) #13
Sergey Ulanov
lgtm
4 years, 3 months ago (2016-09-19 21:16:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344003002/20001
4 years, 3 months ago (2016-09-19 21:17:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/298985)
4 years, 3 months ago (2016-09-20 00:39:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344003002/20001
4 years, 3 months ago (2016-09-20 03:22:34 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 04:09:29 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 04:11:50 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/873700139f1834cd79da404cc4ceeb5c264b7703
Cr-Commit-Position: refs/heads/master@{#419676}

Powered by Google App Engine
This is Rietveld 408576698