chrome/browser/geolocation/chrome_geolocation_permission_context.cc - Issue 23440030: GeolocationPermissionContext: only use origin from embedder url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.cc

Issue 23440030: GeolocationPermissionContext: only use origin from embedder url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use GURL::GetOrigin. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/geolocation/geolocation_infobar_delegate.cc » ('j') | chrome/browser/geolocation/geolocation_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context.cc

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc

index e3bfc924f2cb2f1abdae72804f1179212c514c76..ae15cc48a4f1ca7bdf222afc65343c3d54cd9d92 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc

@@ -94,7 +94,7 @@ void ChromeGeolocationPermissionContext::RequestGeolocationPermission(

return;

}

- GURL embedder = web_contents->GetURL();

+ GURL embedder = web_contents->GetLastCommittedURL().GetOrigin();

if (!requesting_frame.is_valid() || !embedder.is_valid()) {

LOG(WARNING) << "Attempt to use geolocation from an invalid URL: "

<< requesting_frame << "," << embedder

« no previous file with comments | « no previous file | chrome/browser/geolocation/geolocation_infobar_delegate.cc » ('j') | chrome/browser/geolocation/geolocation_infobar_delegate.cc » ('J')