Source/core/html/HTMLMediaElement.cpp - Issue 23440027: Added a new runtime setting for RequireUserGestureForFullscreenRestriction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 23440027: Added a new runtime setting for RequireUserGestureForFullscreenRestriction. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/media/video-play-require-user-gesture.html ('K') | « LayoutTests/media/video-play-require-user-gesture.html ('k') | Source/core/page/Settings.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 7bf8241cebf119da3c3c68434f3c6f65551b64c4..587f75a98ac8f32f11b912fdcb8cdb1a1c4dcc17 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -258,7 +258,7 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document& docum

, m_lastTimeUpdateEventWallTime(0)

, m_lastTimeUpdateEventMovieTime(numeric_limits<double>::max())

, m_loadState(WaitingForSource)

- , m_restrictions(RequireUserGestureForFullscreenRestriction | RequirePageConsentToLoadMediaRestriction)

+ , m_restrictions(RequirePageConsentToLoadMediaRestriction)

, m_preload(MediaPlayer::Auto)

, m_displayMode(Unknown)

, m_cachedTime(MediaPlayer::invalidTime())

@@ -300,9 +300,14 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document& docum

LOG(Media, "HTMLMediaElement::HTMLMediaElement");

ScriptWrappable::init(this);

- if (document.settings() && document.settings()->mediaPlaybackRequiresUserGesture()) {

- addBehaviorRestriction(RequireUserGestureForRateChangeRestriction);

- addBehaviorRestriction(RequireUserGestureForLoadRestriction);

+ if (document.settings()) {

+ if (document.settings()->mediaPlaybackRequiresUserGesture()) {

+ addBehaviorRestriction(RequireUserGestureForRateChangeRestriction);

+ addBehaviorRestriction(RequireUserGestureForLoadRestriction);

+ }

+ if (document.settings()->mediaFullscreenRequiresUserGesture()) {

+ addBehaviorRestriction(RequireUserGestureForFullscreenRestriction);

+ }

}

setHasCustomStyleCallbacks();