Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: Source/testing/runner/CppBoundClass.h

Issue 23440025: TestRunner library classes should be marked as NonCopyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/testing/runner/CppVariant.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/testing/runner/CppBoundClass.h
diff --git a/Source/testing/runner/CppBoundClass.h b/Source/testing/runner/CppBoundClass.h
index 952a41c5340efdf00bc76b782b4d46daccf8d1db..ba6d82ac24d57a8a7f50a112359aa5ac616817a6 100644
--- a/Source/testing/runner/CppBoundClass.h
+++ b/Source/testing/runner/CppBoundClass.h
@@ -44,6 +44,7 @@
#define CppBoundClass_h
#include "CppVariant.h"
+#include "public/platform/WebNonCopyable.h"
#include <map>
#include <memory>
#include <vector>
@@ -59,7 +60,7 @@ typedef std::vector<CppVariant> CppArgumentList;
// CppBoundClass lets you map Javascript method calls and property accesses
// directly to C++ method calls and CppVariant* variable access.
-class CppBoundClass {
+class CppBoundClass : public WebKit::WebNonCopyable {
public:
class PropertyCallback {
public:
@@ -238,10 +239,6 @@ private:
// True if our np_object has been bound to a WebFrame, in which case it must
// be unregistered with V8 when we delete it.
bool m_boundToFrame;
-
-private:
- CppBoundClass(CppBoundClass&);
- CppBoundClass& operator=(const CppBoundClass&);
};
}
« no previous file with comments | « no previous file | Source/testing/runner/CppVariant.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698