TestRunner library classes should be marked as NonCopyable.

public/testing/WebTestProxy.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebTestProxy_h
 #define WebTestProxy_h
 
 #include "WebTask.h"
 #include "WebTestCommon.h"
+#include "public/platform/WebNonCopyable.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebURLError.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/web/WebAXEnums.h"
 #include "public/web/WebDOMMessageEvent.h"
 #include "public/web/WebDataSource.h"
 #include "public/web/WebDragOperation.h"
 #include "public/web/WebEditingAction.h"
 #include "public/web/WebIconURL.h"
 #include "public/web/WebNavigationPolicy.h"
@@ skipping 209 matching lines @@
     bool m_logConsoleOutput;
     int m_chooserCount;
 
     std::auto_ptr<WebKit::WebGeolocationClientMock> m_geolocationClient;
     std::auto_ptr<WebKit::WebMIDIClientMock> m_midiClient;
     std::auto_ptr<WebKit::WebDeviceOrientationClientMock> m_deviceOrientationClient;
     std::auto_ptr<MockWebSpeechRecognizer> m_speechRecognizer;
     std::auto_ptr<MockWebSpeechInputController> m_speechInputController;
     std::auto_ptr<MockWebValidationMessageClient> m_validationMessageClient;
 
+    // FIXME:: We want to move away from this pattern and mark classes
+    // as Noncopyable, but this class is marked as WEBTESTRUNNER_EXPORT
+    // while WebNonCopyable is not, so we cannot inherit from WebNonCopyable.
+    // To overcome the problem, for now not inheriting from WebNonCopyable
+    // but plan to fix it when we make the change of making WebNonCopyable
+    // a macro rather than class. We will have a single way to mark all classes
+    // as Noncopyable.
+    // Tracked under: http://code.google.com/p/chromium/issues/detail?id=229178
 private:
     WebTestProxyBase(WebTestProxyBase&);
     WebTestProxyBase& operator=(const WebTestProxyBase&);
 };
 
 // Use this template to inject methods into your WebViewClient/WebFrameClient
 // implementation required for the running layout tests.
 template<class Base, typename T>
-class WebTestProxy : public Base, public WebTestProxyBase {
+class WebTestProxy : public Base, public WebTestProxyBase, public WebKit::WebNonCopyable {
 public:
     explicit WebTestProxy(T t)
         : Base(t)
     {
     }
 
     virtual ~WebTestProxy() { }
 
     // WebViewClient implementation.
     virtual void didInvalidateRect(const WebKit::WebRect& rect)
@@ skipping 308 matching lines @@
     }
     virtual bool runFileChooser(const WebKit::WebFileChooserParams& params, WebKit::WebFileChooserCompletion* completion)
     {
         return WebTestProxyBase::runFileChooser(params, completion);
     }
 };
 
 }
 
 #endif // WebTestProxy_h