Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 23440020: Call GetDefaultOutputDeviceID() from GetDefaultOutputStreamParameters() instead of specifying an em… (Closed)

Created:
7 years, 3 months ago by tommi (sloooow) - chröme
Modified:
7 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Call GetDefaultOutputDeviceID() from GetDefaultOutputStreamParameters() instead of specifying an empty string. BUG=285437 R=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M media/audio/audio_manager_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
7 years, 3 months ago (2013-09-05 13:16:16 UTC) #1
henrika (OOO until Aug 14)
LGTM
7 years, 3 months ago (2013-09-05 13:18:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/23440020/1
7 years, 3 months ago (2013-09-05 14:58:37 UTC) #3
tommi (sloooow) - chröme
7 years, 3 months ago (2013-09-05 15:01:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r221429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698