Issue 23440009: [android] Fail if all devices drop offline while running tests.

Issue 23440009: [android] Fail if all devices drop offline while running tests. (Closed)

Created:
7 years, 3 months ago by craigdh

Modified:
7 years, 3 months ago

Reviewers:
frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Fail if all devices drop offline while running tests. BUG=278631 TEST=unittest included R=frankf@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220084

Patch Set 3 : clean up list comprehension #

Patch Set 4 : clean up list comprehension #

Patch Set 5 : rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -6 lines)			Patch
	M	build/android/pylib/base/test_dispatcher.py	View	1 2	3 chunks	+16 lines, -6 lines	0 comments	Download
	M	build/android/pylib/base/test_dispatcher_unittest.py	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

craigdh

https://codereview.chromium.org/23440009/diff/1/build/android/pylib/base/test_dispatcher_unittest.py File build/android/pylib/base/test_dispatcher_unittest.py (right): https://codereview.chromium.org/23440009/diff/1/build/android/pylib/base/test_dispatcher_unittest.py#newcode197 build/android/pylib/base/test_dispatcher_unittest.py:197: need an extra line here

7 years, 3 months ago (2013-08-27 19:28:57 UTC) #1

frankf

lgtm w/ nit https://codereview.chromium.org/23440009/diff/6001/build/android/pylib/base/test_dispatcher.py File build/android/pylib/base/test_dispatcher.py (right): https://codereview.chromium.org/23440009/diff/6001/build/android/pylib/base/test_dispatcher.py#newcode250 build/android/pylib/base/test_dispatcher.py:250: for r, tc in zip(runners, test_collections)]) ...

7 years, 3 months ago (2013-08-27 23:10:25 UTC) #3

frankf

https://codereview.chromium.org/23440009/diff/6001/build/android/pylib/base/test_dispatcher_unittest.py File build/android/pylib/base/test_dispatcher_unittest.py (right): https://codereview.chromium.org/23440009/diff/6001/build/android/pylib/base/test_dispatcher_unittest.py#newcode196 build/android/pylib/base/test_dispatcher_unittest.py:196: android_commands.GetAttachedDevices = attached_devices You also really need to use ...

7 years, 3 months ago (2013-08-27 23:15:17 UTC) #4

craigdh

https://codereview.chromium.org/23440009/diff/6001/build/android/pylib/base/test_dispatcher.py File build/android/pylib/base/test_dispatcher.py (right): https://codereview.chromium.org/23440009/diff/6001/build/android/pylib/base/test_dispatcher.py#newcode250 build/android/pylib/base/test_dispatcher.py:250: for r, tc in zip(runners, test_collections)]) On 2013/08/27 23:10:26, ...

7 years, 3 months ago (2013-08-28 17:58:17 UTC) #5

craigdh

7 years, 3 months ago (2013-08-28 20:52:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as r220084 (presubmit successful).

Expand Messages | Collapse Messages