Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chromeos/dbus/dbus_client_bundle_unittest.cc

Issue 2343993003: chromeos: Refactor D-Bus client creation for ash and browser processes (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/dbus_client_bundle.cc ('k') | chromeos/dbus/dbus_clients_browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/dbus_client_bundle_unittest.cc
diff --git a/chromeos/dbus/dbus_client_bundle_unittest.cc b/chromeos/dbus/dbus_client_bundle_unittest.cc
index a1423e682595efe24b6b3aead439d9f275e4e6dd..109498f1964e48e6de54c49e29bff637abb9680b 100644
--- a/chromeos/dbus/dbus_client_bundle_unittest.cc
+++ b/chromeos/dbus/dbus_client_bundle_unittest.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chromeos/dbus/dbus_client_bundle.h"
-
#include "chromeos/dbus/dbus_client_types.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -17,26 +15,6 @@ DBusClientTypeMask AsClientTypeMask(DBusClientType type) {
} // namespace
-// Tests that real and fake clients can be created.
-TEST(DBusClientBundleTest, CreateClientBundle) {
- const DBusClientTypeMask real_clients =
- AsClientTypeMask(DBusClientType::CRAS) |
- AsClientTypeMask(DBusClientType::CROS_DISKS);
- DBusClientBundle bundle(real_clients);
-
- // Real clients are real.
- EXPECT_TRUE(bundle.cras_audio_client());
- EXPECT_TRUE(bundle.cros_disks_client());
- EXPECT_TRUE(bundle.IsUsingReal(DBusClientType::CRAS));
- EXPECT_TRUE(bundle.IsUsingReal(DBusClientType::CROS_DISKS));
-
- // Fake clients are fake.
- EXPECT_TRUE(bundle.permission_broker_client());
- EXPECT_TRUE(bundle.power_manager_client());
- EXPECT_FALSE(bundle.IsUsingReal(DBusClientType::PERMISSION_BROKER));
- EXPECT_FALSE(bundle.IsUsingReal(DBusClientType::POWER_MANAGER));
-}
-
TEST(DBusClientBundleTest, RealClientsFlagParser) {
EXPECT_EQ(AsClientTypeMask(DBusClientType::NONE),
ParseDBusRealClientsList("foo"));
« no previous file with comments | « chromeos/dbus/dbus_client_bundle.cc ('k') | chromeos/dbus/dbus_clients_browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698