chromeos: Refactor D-Bus client creation for ash and browser processes

ash/test/ash_test_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/test/ash_test_helper.h"
 
 #include "ash/accelerators/accelerator_controller_delegate_aura.h"
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/test/material_design_controller_test_api.h"
 #include "ash/common/wm_shell.h"
@@ skipping 75 matching lines @@
   if (!test_shell_delegate_)
     test_shell_delegate_ = new TestShellDelegate;
 
   // Creates MessageCenter since g_browser_process is not created in AshTestBase
   // tests.
   message_center::MessageCenter::Initialize();
 
 #if defined(OS_CHROMEOS)
   // Create DBusThreadManager for testing.
   if (!chromeos::DBusThreadManager::IsInitialized()) {
-    chromeos::DBusThreadManager::Initialize();
+    chromeos::DBusThreadManager::Initialize(

[James Cook, 2016/09/15 22:23:10]

By only initializing ash-process clients in ash tests we should be able to catch
future accidental usage, at least if the developer writes a test.

+        chromeos::DBusThreadManager::PROCESS_ASH);
     dbus_thread_manager_initialized_ = true;
   }
 
   if (!bluez::BluezDBusManager::IsInitialized()) {
     bluez::BluezDBusManager::Initialize(
         chromeos::DBusThreadManager::Get()->GetSystemBus(),
         chromeos::DBusThreadManager::Get()->IsUsingFake(
             chromeos::DBusClientType::BLUETOOTH));
     bluez_dbus_manager_initialized_ = true;
   }
@@ skipping 111 matching lines @@
 bool AshTestHelper::SupportsHostWindowResize() {
 #if defined(OS_WIN)
   return false;
 #else
   return true;
 #endif
 }
 
 }  // namespace test
 }  // namespace ash