Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chromeos/dbus/dbus_thread_manager_unittest.cc

Issue 2343993003: chromeos: Refactor D-Bus client creation for ash and browser processes (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/dbus_thread_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/dbus_thread_manager.h" 5 #include "chromeos/dbus/dbus_thread_manager.h"
6 6
7 #include "chromeos/dbus/dbus_client_types.h" 7 #include "chromeos/dbus/dbus_client_types.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace chromeos { 10 namespace chromeos {
11 11
12 // Tests that clients can be created. 12 // Tests that real and fake clients can be created.
13 TEST(DBusThreadManagerTest, Initialize) { 13 TEST(DBusThreadManagerTest, Initialize) {
14 DBusThreadManager::Initialize(); 14 DBusThreadManager::Initialize();
15 EXPECT_TRUE(DBusThreadManager::IsInitialized()); 15 EXPECT_TRUE(DBusThreadManager::IsInitialized());
16 16
17 DBusThreadManager* manager = DBusThreadManager::Get(); 17 DBusThreadManager* manager = DBusThreadManager::Get();
18 ASSERT_TRUE(manager); 18 ASSERT_TRUE(manager);
19 19
20 // In tests, clients are fake. 20 // In tests, clients are fake.
21 // NOTE: Order matches DBusClientType enum.
22 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::BLUETOOTH));
21 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::CRAS)); 23 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::CRAS));
22 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::CROS_DISKS)); 24 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::CROS_DISKS));
25 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::CRYPTOHOME));
26 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::DEBUG_DAEMON));
27 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::EASY_UNLOCK));
28 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::LORGNETTE_MANAGER));
29 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::SHILL));
30 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::GSM_SMS));
31 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::IMAGE_BURNER));
32 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::MODEM_MESSAGING));
33 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::PERMISSION_BROKER));
34 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::POWER_MANAGER));
35 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::SMS));
36 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::SYSTEM_CLOCK));
37 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::UPDATE_ENGINE));
38 EXPECT_TRUE(manager->IsUsingFake(DBusClientType::ARC_OBB_MOUNTER));
23 39
24 // Clients were created. 40 // Clients were created.
41 EXPECT_TRUE(manager->GetArcObbMounterClient());
25 EXPECT_TRUE(manager->GetCrasAudioClient()); 42 EXPECT_TRUE(manager->GetCrasAudioClient());
26 EXPECT_TRUE(manager->GetCrosDisksClient()); 43 EXPECT_TRUE(manager->GetCrosDisksClient());
44 EXPECT_TRUE(manager->GetCryptohomeClient());
45 EXPECT_TRUE(manager->GetDebugDaemonClient());
46 EXPECT_TRUE(manager->GetEasyUnlockClient());
47 EXPECT_TRUE(manager->GetGsmSMSClient());
48 EXPECT_TRUE(manager->GetImageBurnerClient());
49 EXPECT_TRUE(manager->GetLorgnetteManagerClient());
50 EXPECT_TRUE(manager->GetModemMessagingClient());
51 EXPECT_TRUE(manager->GetPermissionBrokerClient());
52 EXPECT_TRUE(manager->GetPowerManagerClient());
53 EXPECT_TRUE(manager->GetSessionManagerClient());
54 EXPECT_TRUE(manager->GetShillDeviceClient());
55 EXPECT_TRUE(manager->GetShillIPConfigClient());
56 EXPECT_TRUE(manager->GetShillManagerClient());
57 EXPECT_TRUE(manager->GetShillServiceClient());
58 EXPECT_TRUE(manager->GetShillProfileClient());
59 EXPECT_TRUE(manager->GetShillThirdPartyVpnDriverClient());
60 EXPECT_TRUE(manager->GetSMSClient());
61 EXPECT_TRUE(manager->GetSystemClockClient());
62 EXPECT_TRUE(manager->GetUpdateEngineClient());
27 63
28 DBusThreadManager::Shutdown(); 64 DBusThreadManager::Shutdown();
29 EXPECT_FALSE(DBusThreadManager::IsInitialized()); 65 EXPECT_FALSE(DBusThreadManager::IsInitialized());
30 } 66 }
31 67
68 // Tests that clients can be created for the browser process.
69 TEST(DBusThreadManagerTest, InitializeForBrowser) {
70 DBusThreadManager::Initialize(DBusThreadManager::PROCESS_BROWSER);
71 DBusThreadManager* manager = DBusThreadManager::Get();
72 ASSERT_TRUE(manager);
73
74 // Common clients were created.
75 EXPECT_TRUE(manager->GetCrasAudioClient());
76 EXPECT_TRUE(manager->GetCryptohomeClient());
77 EXPECT_TRUE(manager->GetGsmSMSClient());
78 EXPECT_TRUE(manager->GetModemMessagingClient());
79 EXPECT_TRUE(manager->GetPermissionBrokerClient());
80 EXPECT_TRUE(manager->GetPowerManagerClient());
81 EXPECT_TRUE(manager->GetSessionManagerClient());
82 EXPECT_TRUE(manager->GetShillDeviceClient());
83 EXPECT_TRUE(manager->GetShillIPConfigClient());
84 EXPECT_TRUE(manager->GetShillManagerClient());
85 EXPECT_TRUE(manager->GetShillProfileClient());
86 EXPECT_TRUE(manager->GetShillServiceClient());
87 EXPECT_TRUE(manager->GetShillThirdPartyVpnDriverClient());
88 EXPECT_TRUE(manager->GetSMSClient());
89 EXPECT_TRUE(manager->GetSystemClockClient());
90 EXPECT_TRUE(manager->GetUpdateEngineClient());
91
92 // Clients for the browser were created.
93 EXPECT_TRUE(manager->GetArcObbMounterClient());
94 EXPECT_TRUE(manager->GetCrosDisksClient());
95 EXPECT_TRUE(manager->GetDebugDaemonClient());
96 EXPECT_TRUE(manager->GetEasyUnlockClient());
97 EXPECT_TRUE(manager->GetImageBurnerClient());
98 EXPECT_TRUE(manager->GetLorgnetteManagerClient());
99
100 DBusThreadManager::Shutdown();
101 }
102
103 // Tests that clients can be created for the ash process.
104 TEST(DBusThreadManagerTest, InitializeForAsh) {
105 DBusThreadManager::Initialize(DBusThreadManager::PROCESS_ASH);
106 DBusThreadManager* manager = DBusThreadManager::Get();
107 ASSERT_TRUE(manager);
108
109 // Common clients were created.
110 EXPECT_TRUE(manager->GetCrasAudioClient());
111 EXPECT_TRUE(manager->GetCryptohomeClient());
112 EXPECT_TRUE(manager->GetGsmSMSClient());
113 EXPECT_TRUE(manager->GetModemMessagingClient());
114 EXPECT_TRUE(manager->GetPermissionBrokerClient());
115 EXPECT_TRUE(manager->GetPowerManagerClient());
116 EXPECT_TRUE(manager->GetSessionManagerClient());
117 EXPECT_TRUE(manager->GetShillDeviceClient());
118 EXPECT_TRUE(manager->GetShillIPConfigClient());
119 EXPECT_TRUE(manager->GetShillManagerClient());
120 EXPECT_TRUE(manager->GetShillProfileClient());
121 EXPECT_TRUE(manager->GetShillServiceClient());
122 EXPECT_TRUE(manager->GetShillThirdPartyVpnDriverClient());
123 EXPECT_TRUE(manager->GetSMSClient());
124 EXPECT_TRUE(manager->GetSystemClockClient());
125 EXPECT_TRUE(manager->GetUpdateEngineClient());
126
127 // Clients for other processes were not created.
128 EXPECT_FALSE(manager->GetArcObbMounterClient());
129 EXPECT_FALSE(manager->GetCrosDisksClient());
130 EXPECT_FALSE(manager->GetDebugDaemonClient());
131 EXPECT_FALSE(manager->GetEasyUnlockClient());
132 EXPECT_FALSE(manager->GetImageBurnerClient());
133 EXPECT_FALSE(manager->GetLorgnetteManagerClient());
134
135 DBusThreadManager::Shutdown();
136 }
137
32 } // namespace chromeos 138 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/dbus_thread_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698