Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2343993002:
use SkData oriented picture serialize api (Closed)
|
Created:
4 years, 3 months ago by reed1 Modified:
4 years, 3 months ago CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag.
BUG=647756
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/6cead0b4b4231d47784fa13b94fb91d4dd12080e
Cr-Commit-Position: refs/heads/master@{#420479}
Patch Set 1 #Patch Set 2 : fix webkit instance #
Total comments: 1
Patch Set 3 : remove another unused SkStream.h include #
Total comments: 6
Patch Set 4 : use std::move #Patch Set 5 : use DCHECK_GT consistently #Patch Set 6 : doh -- use 0u for template bad guesses #
Messages
Total messages: 52 (35 generated)
Description was changed from ========== use SkData oriented picture serialize api BUG= ========== to ========== use SkData oriented picture serialize api BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by reed@google.com to run a CQ dry run
reed@google.com changed reviewers: + fmalita@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
reed@google.com changed reviewers: + dtrainor@chromium.org, nyquist@chromium.org, vollick@chromium.org, wez@chromium.org
need OWNERS for cc/blimp and blimp/engine/renderer
Description was changed from ========== use SkData oriented picture serialize api BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== use SkData oriented picture serialize api, allowing us to deprecate the older api behind SK_SUPPORT_LEGACY_STREAM_DATA BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
non-owner LGTM https://codereview.chromium.org/2343993002/diff/20001/blimp/engine/renderer/b... File blimp/engine/renderer/blimp_engine_picture_cache.cc (right): https://codereview.chromium.org/2343993002/diff/20001/blimp/engine/renderer/b... blimp/engine/renderer/blimp_engine_picture_cache.cc:61: cc::PictureData(picture->uniqueID(), data))); nit: std::move(data)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
nit: Could you clean up the CL description, please (I think it's just capitalization & punctuation that needs fixing, assuming I'm understanding the meaning correctly :). Also, is there a bug # tracking this work?
https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... File blimp/engine/renderer/blimp_engine_picture_cache.cc (right): https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... blimp/engine/renderer/blimp_engine_picture_cache.cc:55: DCHECK_GE(data->size(), 0u); Should this be DCHECK_GT? Is it possible for a picture to serialize to zero bytes? https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... File blimp/test/support/compositor/picture_cache_test_support.cc (right): https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... blimp/test/support/compositor/picture_cache_test_support.cc:33: DCHECK(data->size()); nit: I realise this was already in this state, but can we make this consistent with the other blimp call-site and use DCHECK_GT(...)?
Description was changed from ========== use SkData oriented picture serialize api, allowing us to deprecate the older api behind SK_SUPPORT_LEGACY_STREAM_DATA BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag. BUG=647756 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
I suggest we move the question of zero-length-or-not serialized pictures to a separate CL, since that may (for completeness) involve changes in other places. I'd rather only face reverts/acceptance of this CL around the API refactoring... https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... File blimp/engine/renderer/blimp_engine_picture_cache.cc (right): https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... blimp/engine/renderer/blimp_engine_picture_cache.cc:55: DCHECK_GE(data->size(), 0u); On 2016/09/16 16:34:02, Wez wrote: > Should this be DCHECK_GT? Is it possible for a picture to serialize to zero > bytes? Well, an empty picture could be zero bytes. I don't know the assumption of the caller regarding that. https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... File blimp/test/support/compositor/picture_cache_test_support.cc (right): https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... blimp/test/support/compositor/picture_cache_test_support.cc:33: DCHECK(data->size()); On 2016/09/16 16:34:02, Wez wrote: > nit: I realise this was already in this state, but can we make this consistent > with the other blimp call-site and use DCHECK_GT(...)? That seems related to the other question about zero-length serialization. Is it a contract of the caller that the picture is never empty?
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... File blimp/engine/renderer/blimp_engine_picture_cache.cc (right): https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... blimp/engine/renderer/blimp_engine_picture_cache.cc:55: DCHECK_GE(data->size(), 0u); On 2016/09/16 20:06:29, reed1 wrote: > On 2016/09/16 16:34:02, Wez wrote: > > Should this be DCHECK_GT? Is it possible for a picture to serialize to zero > > bytes? > > Well, an empty picture could be zero bytes. I don't know the assumption of the > caller regarding that. Oh my question was just a question, to check that DCHECK_GE really is what we want here. :) https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... File blimp/test/support/compositor/picture_cache_test_support.cc (right): https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... blimp/test/support/compositor/picture_cache_test_support.cc:33: DCHECK(data->size()); On 2016/09/16 20:06:29, reed1 wrote: > On 2016/09/16 16:34:02, Wez wrote: > > nit: I realise this was already in this state, but can we make this consistent > > with the other blimp call-site and use DCHECK_GT(...)? > > That seems related to the other question about zero-length serialization. Is it > a contract of the caller that the picture is never empty? No, my point here was simply to be consistent in using DCHECK_GE(foo, 0) versus DCHECK(foo).
blimp/ LGTM
On 2016/09/17 01:50:03, Wez wrote: > https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... > File blimp/engine/renderer/blimp_engine_picture_cache.cc (right): > > https://codereview.chromium.org/2343993002/diff/40001/blimp/engine/renderer/b... > blimp/engine/renderer/blimp_engine_picture_cache.cc:55: DCHECK_GE(data->size(), > 0u); > On 2016/09/16 20:06:29, reed1 wrote: > > On 2016/09/16 16:34:02, Wez wrote: > > > Should this be DCHECK_GT? Is it possible for a picture to serialize to zero > > > bytes? > > > > Well, an empty picture could be zero bytes. I don't know the assumption of the > > caller regarding that. > > Oh my question was just a question, to check that DCHECK_GE really is what we > want here. :) > > https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... > File blimp/test/support/compositor/picture_cache_test_support.cc (right): > > https://codereview.chromium.org/2343993002/diff/40001/blimp/test/support/comp... > blimp/test/support/compositor/picture_cache_test_support.cc:33: > DCHECK(data->size()); > On 2016/09/16 20:06:29, reed1 wrote: > > On 2016/09/16 16:34:02, Wez wrote: > > > nit: I realise this was already in this state, but can we make this > consistent > > > with the other blimp call-site and use DCHECK_GT(...)? > > > > That seems related to the other question about zero-length serialization. Is > it > > a contract of the caller that the picture is never empty? > > No, my point here was simply to be consistent in using DCHECK_GE(foo, 0) versus > DCHECK(foo). Ah, gotcha. I will make that change.
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org, wez@chromium.org Link to the patchset: https://codereview.chromium.org/2343993002/#ps100001 (title: "doh -- use 0u for template bad guesses")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
cc/blimp/picture_data_conversions_unittest.cc
cc/test/picture_cache_model.cc
danakj@chromium.org changed reviewers: + danakj@chromium.org
cc LGTM
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag. BUG=647756 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag. BUG=647756 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag. BUG=647756 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag. BUG=647756 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/6cead0b4b4231d47784fa13b94fb91d4dd12080e Cr-Commit-Position: refs/heads/master@{#420479} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/6cead0b4b4231d47784fa13b94fb91d4dd12080e Cr-Commit-Position: refs/heads/master@{#420479} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
