chromeos/printing/printer_translator_unittest.cc - Issue 2343983004: Add PPDProvider barebones implementation and associated cache skeleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/printing/printer_translator_unittest.cc

Issue 2343983004: Add PPDProvider barebones implementation and associated cache skeleton. (Closed)

Patch Set: Initial PPDProvider/PPDCache implementation. Also, add associated unittests. This doesn't plumb th… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/printing/printer_translator_unittest.cc

diff --git a/chromeos/printing/printer_translator_unittest.cc b/chromeos/printing/printer_translator_unittest.cc

index 51edff9df7d5716b97080cb05b937dac2af39ed1..4b5556296af7322c084f47676579de05e6324cf4 100644

--- a/chromeos/printing/printer_translator_unittest.cc

+++ b/chromeos/printing/printer_translator_unittest.cc

@@ -104,8 +104,6 @@ TEST(PrinterTranslatorTest, PrinterToPrefPpdReferenceLazy) {

EXPECT_FALSE(actual->HasKey("ppd_reference.effective_model"));

}

-// FIXME add a test that we don't set fields that are empty.

TEST(PrinterTranslatorTest, PrefToPrinterRoundTrip) {

base::DictionaryValue preference;

preference.SetString("id", kGUID);