Add PPDProvider barebones implementation and associated cache skeleton.

chromeos/printing/printer_translator_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "base/test/values_test_util.h"
 #include "base/values.h"
 #include "chromeos/printing/printer_configuration.h"
 #include "chromeos/printing/printer_translator.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 namespace printing {
 
 // Printer test data
 const char kGUID[] = "GUID-GUID-GUID";
 const char kName[] = "Chrome Super Printer";
 const char kDescription[] = "first star on the left";
 const char kMake[] = "Chrome";
 const char kModel[] = "Inktastic Laser Magic";
 const char kUri[] = "ipp://printy.domain.co:555/ipp/print";
 const char kUUID[] = "UUID-UUID-UUID";
 
-// PPDFile test data
-const int kPPDiD = 13334;
-const char kFileName[] = "path/to/ppd/file.ppd";
-const int kVersion = 47773;
-const bool kQuirks = false;
+// PpdReference test data
+const char kUserSuppliedPpdUrl[] = "/some/path/to/user.url";
+const char kEffectiveManufacturer[] = "Ehch Pea";
+const char kEffectiveModel[] = "PrintBlaster 2000";
 
 TEST(PrinterTranslatorTest, PrefToPrinterMissingId) {
   base::DictionaryValue value;
   std::unique_ptr<Printer> printer = PrefToPrinter(value);
 
   EXPECT_FALSE(printer);
 }
 
 TEST(PrinterTranslatorTest, PrefToPrinter) {
   base::DictionaryValue preference;
@@ skipping 30 matching lines @@
 
   base::ExpectDictStringValue("GLOBALLY_UNIQUE_ID", *pref, "id");
   base::ExpectDictStringValue(kName, *pref, "display_name");
   base::ExpectDictStringValue(kDescription, *pref, "description");
   base::ExpectDictStringValue(kMake, *pref, "manufacturer");
   base::ExpectDictStringValue(kModel, *pref, "model");
   base::ExpectDictStringValue(kUri, *pref, "uri");
   base::ExpectDictStringValue(kUUID, *pref, "uuid");
 }
 
-TEST(PrinterTranslatorTest, PrinterToPrefPPDFile) {
-  Printer::PPDFile ppd;
-  ppd.id = kPPDiD;
-  ppd.file_name = kFileName;
-  ppd.version_number = kVersion;
-  ppd.from_quirks_server = kQuirks;
-
+TEST(PrinterTranslatorTest, PrinterToPrefPpdReference) {
   Printer printer("UNIQUE_ID");
-  printer.SetPPD(base::MakeUnique<Printer::PPDFile>(std::move(ppd)));
+  auto* ppd = printer.mutable_ppd_reference();
+  ppd->user_supplied_ppd_url = kUserSuppliedPpdUrl;
+  ppd->effective_manufacturer = kEffectiveManufacturer;
+  ppd->effective_model = kEffectiveModel;
 
   std::unique_ptr<base::DictionaryValue> actual = PrinterToPref(printer);
 
-  base::ExpectDictIntegerValue(kPPDiD, *actual, "ppd.id");
-  base::ExpectDictStringValue(kFileName, *actual, "ppd.file_name");
-  base::ExpectDictIntegerValue(kVersion, *actual, "ppd.version_number");
-  base::ExpectDictBooleanValue(kQuirks, *actual, "ppd.from_quirks_server");
+  base::ExpectDictStringValue(kUserSuppliedPpdUrl, *actual,
+                              "ppd_reference.user_supplied_ppd_url");
+  base::ExpectDictStringValue(kEffectiveManufacturer, *actual,
+                              "ppd_reference.effective_manufacturer");
+  base::ExpectDictStringValue(kEffectiveModel, *actual,
+                              "ppd_reference.effective_model");
 }
 
+// Make sure we don't serialize empty fields.
+TEST(PrinterTranslatorTest, PrinterToPrefPpdReferenceLazy) {
+  Printer printer("UNIQUE_ID");
+  std::unique_ptr<base::DictionaryValue> actual = PrinterToPref(printer);
+
+  EXPECT_FALSE(actual->HasKey("ppd_reference.user_supplied_ppd_url"));
+  EXPECT_FALSE(actual->HasKey("ppd_reference.effective_manufacturer"));
+  EXPECT_FALSE(actual->HasKey("ppd_reference.effective_model"));
+}
+
+// FIXME add a test that we don't set fields that are empty.

[skau, 2016/10/14 22:10:17]

FIXME

[Carlson, 2016/10/14 23:05:56]

apparently chromium presubmits don't pickup FIXME?  

FIXME was stale (test is already in)

+
 TEST(PrinterTranslatorTest, PrefToPrinterRoundTrip) {
   base::DictionaryValue preference;
   preference.SetString("id", kGUID);
   preference.SetString("display_name", kName);
   preference.SetString("description", kDescription);
   preference.SetString("manufacturer", kMake);
   preference.SetString("model", kModel);
   preference.SetString("uri", kUri);
   preference.SetString("uuid", kUUID);
 
-  preference.SetInteger("ppd.id", kPPDiD);
-  preference.SetString("ppd.file_name", kFileName);
-  preference.SetInteger("ppd.version_number", kVersion);
-  preference.SetBoolean("ppd.from_quirks_server", kQuirks);
+  preference.SetString("ppd_reference.user_supplied_ppd_url",
+                       kUserSuppliedPpdUrl);
+  preference.SetString("ppd_reference.effective_manufacturer",
+                       kEffectiveManufacturer);
+  preference.SetString("ppd_reference.effective_model", kEffectiveModel);
 
   std::unique_ptr<Printer> printer = PrefToPrinter(preference);
   std::unique_ptr<base::DictionaryValue> pref_copy = PrinterToPref(*printer);
 
   EXPECT_TRUE(preference.Equals(pref_copy.get()));
 }
 
 }  // namespace printing
 }  // namespace chromeos