Issue 2343973003: Prototype of fix for mac FTDI crash where the entire trace is read even if there is an error (e.g.,…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2343973003: Prototype of fix for mac FTDI crash where the entire trace is read even if there is an error (e.g.,…

Created:
4 years, 3 months ago by aschulman

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[battor_agent] Prototype of fix for mac FTDI crash where the entire trace is read even if there is an error (e.g., lost bytes). BUG=634188

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -49 lines)			Patch
	M	tools/battor_agent/battor_agent.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
	M	tools/battor_agent/battor_agent.cc	View		11 chunks	+39 lines, -46 lines	0 comments	Download

Messages

Total messages: 3 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

aschulman

4 years, 1 month ago (2016-10-26 07:19:18 UTC) #2

On 2016/09/15 23:52:25, aschulman wrote:
> Description was changed from
> 
> ==========
> Prototype of fix for mac FTDI crash where the entire trace is read even if
there
> is an error (e.g., lost bytes).
> 
> BUG=
> ==========
> 
> to
> 
> ==========
> [battor_agent] Prototype of fix for mac FTDI crash where the entire trace is
> read even if there is an error (e.g., lost bytes).
> 
> BUG=
> ==========

This CL may not be needed since the Macs in the testbed are rebooted for each
run.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages