Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2343973002: Fix speaker flipping issue when the device rotates. (Closed)

Created:
4 years, 3 months ago by jennyz
Modified:
4 years, 3 months ago
Reviewers:
cychiang
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix speaker flipping issue when the device rotates. BUG=646037 Committed: https://crrev.com/7ffb5a509d6f5474544c9bfedd4fe1053c66d3f1 Cr-Commit-Position: refs/heads/master@{#418991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/common/system/chromeos/audio/tray_audio_chromeos.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jennyz
4 years, 3 months ago (2016-09-15 19:10:35 UTC) #2
cychiang
On 2016/09/15 19:10:35, jennyz wrote: LGTM. Thanks a lot!
4 years, 3 months ago (2016-09-15 20:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343973002/1
4 years, 3 months ago (2016-09-15 20:52:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 21:47:53 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 21:51:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ffb5a509d6f5474544c9bfedd4fe1053c66d3f1
Cr-Commit-Position: refs/heads/master@{#418991}

Powered by Google App Engine
This is Rietveld 408576698