Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2343933002: Revert of SkFontData to use smart pointers. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkFontData to use smart pointers. (patchset #3 id:40001 of https://codereview.chromium.org/2339273002/ ) Reason for revert: Killing Mac Original issue's description: > SkFontData to use smart pointers. > > The SkFontData type is not exposed externally, so any method which uses > it can be updated to use smart pointers without affecting external > users. Updating this first will make updating the public API much > easier. > > This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to > std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It > appears that no one outside Skia is currently using SkStream::NewfromFile > so this is a good time to update it as well. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 > > Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c TBR=mtklein@chromium.org,halcanary@google.com,mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/606add3dfb2f6d1dc3ee4921876e7c9fa01643f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -269 lines) Patch
M bench/nanobench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M dm/DMSrcSink.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M include/core/SkStream.h View 1 chunk +5 lines, -3 lines 0 comments Download
M include/core/SkTypeface.h View 3 chunks +9 lines, -7 lines 0 comments Download
M include/ports/SkFontMgr.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/utils/mac/SkCGUtils.h View 1 chunk +11 lines, -3 lines 0 comments Download
M samplecode/SampleAnimator.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/animator/SkAnimateMaker.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkAnimator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkFontDescriptor.h View 3 chunks +11 lines, -10 lines 0 comments Download
M src/core/SkFontDescriptor.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M src/core/SkFontMgr.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/core/SkStream.cpp View 2 chunks +11 lines, -10 lines 0 comments Download
M src/core/SkTypeface.cpp View 5 chunks +11 lines, -12 lines 0 comments Download
M src/images/SkMovie.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontConfigTypeface.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 6 chunks +11 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 7 chunks +16 lines, -19 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_FontConfigInterface.cpp View 6 chunks +18 lines, -19 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 9 chunks +33 lines, -35 lines 0 comments Download
M src/ports/SkFontMgr_custom.cpp View 11 chunks +29 lines, -31 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 9 chunks +24 lines, -25 lines 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkWhitelistTypefaces.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/utils/mac/SkCreateCGImageRef.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
M src/utils/mac/SkStream_mac.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/BadIcoTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/CodecTest.cpp View 15 chunks +28 lines, -17 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M tests/ExifTest.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/SerializationTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/YUVTest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M tools/Resources.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/dump_record.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/get_images_from_skps.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/viewer/SKPSlide.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bungeman-skia
Created Revert of SkFontData to use smart pointers.
4 years, 3 months ago (2016-09-15 17:57:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343933002/1
4 years, 3 months ago (2016-09-15 17:57:25 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:57:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/606add3dfb2f6d1dc3ee4921876e7c9fa01643f9

Powered by Google App Engine
This is Rietveld 408576698