Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2343923003: Make event.composedPath() on window behave the same way as that on document (Closed)

Created:
4 years, 3 months ago by hayato
Modified:
4 years, 2 months ago
Reviewers:
tkent, ojan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make event.composedPath() on window behave the same way as that on document The spec is: https://dom.spec.whatwg.org/#dom-event-composedpath The relevant change of the spec: https://github.com/whatwg/dom/pull/327 I have updated the DOM Standard to clarify the behavior of event.composedPath() on window. The current Blink's implementation of event.composedPath() on window returns just [window]. Now, event.composedPath() on window behaves the same way as that on document. BUG=645527 Committed: https://crrev.com/92dd0aa2f5587f380f7f8f7c58d1f9a9862e3254 Cr-Commit-Position: refs/heads/master@{#422368}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (15 generated)
hayato
rebased
4 years, 2 months ago (2016-10-03 01:36:38 UTC) #6
hayato
PTAL. I will send a PSA to blink-dev because this is a web facing change.
4 years, 2 months ago (2016-10-03 01:41:01 UTC) #11
tkent
Do other browsers have composedPath()? How does it work on Window?
4 years, 2 months ago (2016-10-03 01:57:30 UTC) #12
hayato
On 2016/10/03 at 01:57:30, tkent wrote: > Do other browsers have composedPath()? How does it ...
4 years, 2 months ago (2016-10-03 02:27:21 UTC) #14
tkent
ok, lgtm. This CL won't increase compatibility risk. I think only chromestatus.com entry is necessary.
4 years, 2 months ago (2016-10-03 03:19:03 UTC) #18
hayato
Thanks. I have added an entry: https://www.chromestatus.com/feature/4661261711179776
4 years, 2 months ago (2016-10-03 03:58:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343923003/20001
4 years, 2 months ago (2016-10-03 03:59:13 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 04:04:06 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 04:06:24 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92dd0aa2f5587f380f7f8f7c58d1f9a9862e3254
Cr-Commit-Position: refs/heads/master@{#422368}

Powered by Google App Engine
This is Rietveld 408576698