Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2343923002: Add TODO to remove page_load_histograms.h/.cc (Closed)

Created:
4 years, 3 months ago by Bryan McQuade
Modified:
4 years, 3 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TODO to remove page_load_histograms.h/.cc BUG=384330 Committed: https://crrev.com/c8e3fceef1dec0b672f9c98fcf57f128b6793712 Cr-Commit-Position: refs/heads/master@{#418983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/renderer/page_load_histograms.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bryan McQuade
rkaplow, I committed my update to histograms.xml before noticing your request to add a TODO. ...
4 years, 3 months ago (2016-09-15 17:51:34 UTC) #4
rkaplow
lgtm ty!
4 years, 3 months ago (2016-09-15 21:13:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343923002/1
4 years, 3 months ago (2016-09-15 21:23:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 21:30:53 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 21:34:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8e3fceef1dec0b672f9c98fcf57f128b6793712
Cr-Commit-Position: refs/heads/master@{#418983}

Powered by Google App Engine
This is Rietveld 408576698