Run SVGs through nanobench on all Perf bots

Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002

Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52

[rmistry, 2016-09-15 17:06:18]

Description was changed from

==========
Use SVG as a Nanobench source

BUG=skia:5757
==========

to

==========
Use SVG as a Nanobench source

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

[rmistry, 2016-09-15 17:12:35]

Description was changed from

==========
Use SVG as a Nanobench source

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

to

==========
Use SVG as a Nanobench source.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=1

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

[rmistry, 2016-09-15 17:36:19]

Description was changed from

==========
Use SVG as a Nanobench source.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=1

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

to

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=40001

Output is here:
https://luci-milo.appspot.com/swarming/task/3147afd965159f10
Nanobench did run on SVGs.

It appears to use the default config and scales: 
--config 8888 gpu nonrendering angle hwui f16 srgb msaa16 nvpr16 nvprdit16
--scales 1.0 1.1


BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

[rmistry, 2016-09-15 17:36:47]

rmistry@google.com changed reviewers:
+ fmalita@chromium.org, jcgregorio@google.com

[rmistry, 2016-09-15 17:38:01]

On 2016/09/15 17:36:48, rmistry wrote:

In the original email Florin mentioned that we might want to run something like:
nanobench --config 8888 gpu --scales 1 2 4 --sourceType svg --svgs
<path_to_svgs_dir>

But the way the recipe is setup it looks like it is using the following:
--config 8888 gpu nonrendering angle hwui f16 srgb msaa16 nvpr16 nvprdit16
--scales 1.0 1.1

I do not know how to change that to do something special for SVGs that does not
impact the other sources.

[rmistry, 2016-09-15 17:45:28]

Patchset #2 (id:20001) has been deleted

[rmistry, 2016-09-15 17:45:35]

Patchset #2 (id:40001) has been deleted

[rmistry, 2016-09-15 17:50:30]

Description was changed from

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=40001

Output is here:
https://luci-milo.appspot.com/swarming/task/3147afd965159f10
Nanobench did run on SVGs.

It appears to use the default config and scales: 
--config 8888 gpu nonrendering angle hwui f16 srgb msaa16 nvpr16 nvprdit16
--scales 1.0 1.1


BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

to

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=40001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147afd965159f10
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

[rmistry, 2016-09-15 17:54:14]

rmistry@google.com changed reviewers:
+ mtklein@google.com

[rmistry, 2016-09-15 17:54:15]

Florin and Mike:

At Patchset2 I added additional scales for Android GPU bots- 2.0 and 4.0.
Because of the way the code is setup, this will impact all sourceTypes (not just
SVGs). I do not know how to make the new scales apply to only SVGs the way
things are currently structured.

https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
infra/bots/recipes/swarm_trigger.py:270: # return got_revision
This is just for testing purposes.

[rmistry, 2016-09-15 18:01:02]

Description was changed from

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=40001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147afd965159f10
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

to

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=80001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

[mtklein_C, 2016-09-15 18:02:51]

On 2016/09/15 at 17:54:15, rmistry wrote:
> Florin and Mike:
> 
> At Patchset2 I added additional scales for Android GPU bots- 2.0 and 4.0.
> Because of the way the code is setup, this will impact all sourceTypes (not
just SVGs). I do not know how to make the new scales apply to only SVGs the way
things are currently structured.
> 
>
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> File infra/bots/recipes/swarm_trigger.py (right):
> 
>
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> infra/bots/recipes/swarm_trigger.py:270: # return got_revision
> This is just for testing purposes.

As currently written, there's no way in nanobench to run some pictures under one
set of scales and others under another, but it's a pretty straightforward change
if you want to do that.

[rmistry, 2016-09-15 18:11:33]

On 2016/09/15 18:02:51, mtklein_C wrote:
> On 2016/09/15 at 17:54:15, rmistry wrote:
> > Florin and Mike:
> > 
> > At Patchset2 I added additional scales for Android GPU bots- 2.0 and 4.0.
> > Because of the way the code is setup, this will impact all sourceTypes (not
> just SVGs). I do not know how to make the new scales apply to only SVGs the
way
> things are currently structured.
> > 
> >
>
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> > File infra/bots/recipes/swarm_trigger.py (right):
> > 
> >
>
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> > infra/bots/recipes/swarm_trigger.py:270: # return got_revision
> > This is just for testing purposes.
> 
> As currently written, there's no way in nanobench to run some pictures under
one
> set of scales and others under another, but it's a pretty straightforward
change
> if you want to do that.

I am about to leave for the day soonish, so-

If running additional scales through the other sourceTypes for Android GPU is
acceptable then we should probably land this as is.

If we would rather not run additional scales then we could:
* Land this using the default scales (1.0, 1.1). And then somebody (Florin? :))
adds that functionality to nanobench.
* We make the change to nanobench first and then update this CL.

[mtklein_C, 2016-09-15 18:13:15]

On 2016/09/15 at 18:11:33, rmistry wrote:
> On 2016/09/15 18:02:51, mtklein_C wrote:
> > On 2016/09/15 at 17:54:15, rmistry wrote:
> > > Florin and Mike:
> > > 
> > > At Patchset2 I added additional scales for Android GPU bots- 2.0 and 4.0.
> > > Because of the way the code is setup, this will impact all sourceTypes
(not
> > just SVGs). I do not know how to make the new scales apply to only SVGs the
way
> > things are currently structured.
> > > 
> > >
> >
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> > > File infra/bots/recipes/swarm_trigger.py (right):
> > > 
> > >
> >
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> > > infra/bots/recipes/swarm_trigger.py:270: # return got_revision
> > > This is just for testing purposes.
> > 
> > As currently written, there's no way in nanobench to run some pictures under
one
> > set of scales and others under another, but it's a pretty straightforward
change
> > if you want to do that.
> 
> I am about to leave for the day soonish, so-
> 
> If running additional scales through the other sourceTypes for Android GPU is
acceptable then we should probably land this as is.
> 
> If we would rather not run additional scales then we could:
> * Land this using the default scales (1.0, 1.1). And then somebody (Florin?
:)) adds that functionality to nanobench.
> * We make the change to nanobench first and then update this CL.

I think I'd land with 1, 1.1, then Florin, Brian and I can figure out what we
want drawn at what scales.

[rmistry, 2016-09-15 18:17:02]

On 2016/09/15 18:13:15, mtklein_C wrote:
> On 2016/09/15 at 18:11:33, rmistry wrote:
> > On 2016/09/15 18:02:51, mtklein_C wrote:
> > > On 2016/09/15 at 17:54:15, rmistry wrote:
> > > > Florin and Mike:
> > > > 
> > > > At Patchset2 I added additional scales for Android GPU bots- 2.0 and
4.0.
> > > > Because of the way the code is setup, this will impact all sourceTypes
> (not
> > > just SVGs). I do not know how to make the new scales apply to only SVGs
the
> way
> > > things are currently structured.
> > > > 
> > > >
> > >
>
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> > > > File infra/bots/recipes/swarm_trigger.py (right):
> > > > 
> > > >
> > >
>
https://codereview.chromium.org/2343903002/diff/80001/infra/bots/recipes/swar...
> > > > infra/bots/recipes/swarm_trigger.py:270: # return got_revision
> > > > This is just for testing purposes.
> > > 
> > > As currently written, there's no way in nanobench to run some pictures
under
> one
> > > set of scales and others under another, but it's a pretty straightforward
> change
> > > if you want to do that.
> > 
> > I am about to leave for the day soonish, so-
> > 
> > If running additional scales through the other sourceTypes for Android GPU
is
> acceptable then we should probably land this as is.
> > 
> > If we would rather not run additional scales then we could:
> > * Land this using the default scales (1.0, 1.1). And then somebody (Florin?
> :)) adds that functionality to nanobench.
> > * We make the change to nanobench first and then update this CL.
> 
> I think I'd land with 1, 1.1, then Florin, Brian and I can figure out what we
> want drawn at what scales.

SGTM. This is now ready for review.

[rmistry, 2016-09-16 11:39:46]

Friendly ping.

[mtklein, 2016-09-16 12:13:06]

lgtm

[rmistry, 2016-09-16 17:53:37]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-09-16 17:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:32:36]

Description was changed from

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=80001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
==========

to

==========
Run SVGs through nanobench on all Perf bots.

Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen
buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1
revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002
rietveld=https://codereview.chromium.org patchset=80001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002

Committed:
https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52
==========

[commit-bot: I haz the power, 2016-09-16 18:32:37]

Committed patchset #5 (id:120001) as
https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52

[rmistry, 2016-09-16 19:06:43]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/2348563003/ by rmistry@google.com.

The reason for reverting is: Causing failures:
https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-Ma....