JSON string decoding for VM debugger

runtime/platform/json.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/json.h"
 
 #include "platform/assert.h"
 #include "platform/globals.h"
 #include "platform/utils.h"
 #include "vm/os.h"
@@ skipping 380 matching lines @@
     case JSONScanner::TokenTrue:
     case JSONScanner::TokenFalse:
     case JSONScanner::TokenNull:
       return kLiteral;
     default:
       return kNone;
   }
 }
 
 
-void JSONReader::GetValueChars(char* buf, intptr_t buflen) const {
+void JSONReader::GetRawValueChars(char* buf, intptr_t buflen) const {
   if (Type() == kNone) {
     return;
   }
   intptr_t max = buflen - 1;

[regis, 2013/08/26 20:12:24]

const

[hausner, 2013/08/26 20:57:40]

Not in this case, unless I initialize it as min(buflen-1, ValueLen()).

   if (ValueLen() < max) {
     max = ValueLen();
   }
   const char* val = ValueChars();
   intptr_t i = 0;
   for (; i < max; i++) {
     buf[i] = val[i];
   }
   buf[i] = '\0';
 }
 
 
+void JSONReader::GetDecodedValueChars(char* buf, intptr_t buflen) const {
+  if (Type() == kNone) {
+    return;
+  }
+  intptr_t max = buflen - 1;

[regis, 2013/08/26 20:12:24]

const

[regis, 2013/08/26 20:12:24]

How about last_idx instead of max?

[hausner, 2013/08/26 20:57:40]

Done.

[hausner, 2013/08/26 20:57:40]

Done.

+  intptr_t value_len = ValueLen();

[regis, 2013/08/26 20:12:24]

const

[hausner, 2013/08/26 20:57:40]

Done.

+  const char* val = ValueChars();
+  intptr_t buf_idx = 0;
+  intptr_t val_idx = 0;
+  while ((buf_idx < max) && (val_idx < value_len)) {
+    char ch = val[val_idx];
+    val_idx++;
+    buf[buf_idx] = ch;

[regis, 2013/08/26 20:12:24]

You could move this buf[buf_idx] = ch to an else part and to the default case,
as to not write twice into the same location.

[hausner, 2013/08/26 20:57:40]

True. OTOH I find it a bit more readable like this and the only characters that
cause two writes are escaped characters. If you feel strongly about it I can
revisit it in a follow-up change.

+    if ((ch == '\\') && (val_idx < value_len)) {
+      switch (val[val_idx]) {
+        case '"':
+        case '\\':
+        case '/':
+          buf[buf_idx] = val[val_idx];
+          val_idx++;
+          break;
+        case 'b':
+          buf[buf_idx] = '\b';
+          val_idx++;
+          break;
+        case 'f':
+          buf[buf_idx] = '\f';
+          val_idx++;
+          break;
+        case 'n':
+          buf[buf_idx] = '\n';
+          val_idx++;
+          break;
+        case 'r':
+          buf[buf_idx] = '\r';
+          val_idx++;
+          break;
+        case 't':
+          buf[buf_idx] = '\t';
+          val_idx++;
+          break;
+        case 'u':
+          // \u00XX
+          // If the value is malformed or > 255, ignore and copy the
+          // encoded characters.
+          if ((val_idx < value_len - 4) &&
+              (val[val_idx + 1] == '0') && (val[val_idx + 2] == '0') &&
+              Utils::IsHexDigit(val[val_idx + 3]) &&
+              Utils::IsHexDigit(val[val_idx + 4])) {
+            buf[buf_idx] = 16 * Utils::HexDigitToInt(val[val_idx + 3]) +
+                Utils::HexDigitToInt(val[val_idx + 4]);
+            val_idx += 5;
+          }
+          break;
+        default:
+          // Nothing. Copy the character after the backslash
+          // in the next loop iteration.
+          break;
+      }
+    }
+    buf_idx++;
+  }
+  buf[buf_idx] = '\0';
+}
+
+
 TextBuffer::TextBuffer(intptr_t buf_size) {
   ASSERT(buf_size > 0);
   buf_ = reinterpret_cast<char*>(malloc(buf_size));
   buf_size_ = buf_size;
   Clear();
 }
 
 
 TextBuffer::~TextBuffer() {
   free(buf_);
@@ skipping 140 matching lines @@
     // the debugger front-end.
     intptr_t new_size = buf_size_ + len + kBufferSpareCapacity;
     char* new_buf = reinterpret_cast<char*>(realloc(buf_, new_size));
     ASSERT(new_buf != NULL);
     buf_ = new_buf;
     buf_size_ = new_size;
   }
 }
 
 }  // namespace dart