Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: pkg/analyzer/lib/src/generated/type_system.dart

Issue 2343863004: ignore `dynamic` when doing inference (Closed)
Patch Set: add changelog note Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/type_system.dart
diff --git a/pkg/analyzer/lib/src/generated/type_system.dart b/pkg/analyzer/lib/src/generated/type_system.dart
index 0488553c43014ca14e9210c463bb5279263b57a8..4899d9a2821173456277694060e6a695df1bc2b5 100644
--- a/pkg/analyzer/lib/src/generated/type_system.dart
+++ b/pkg/analyzer/lib/src/generated/type_system.dart
@@ -1640,8 +1640,12 @@ class _StrongInferenceTypeSystem extends StrongTypeSystemImpl {
// We already know L <: T2, for some L.
// So update L to reflect the new constraint LUB(L, T1) <: T2
//
- bound.lower =
- _typeSystem.getLeastUpperBound(_typeProvider, bound.lower, t1);
+
+ // Heuristic: we intentionally ignore `dynamic` when doing inference.
+ if (!t1.isDynamic) {
+ bound.lower =
+ _typeSystem.getLeastUpperBound(_typeProvider, bound.lower, t1);
+ }
// Optimistically assume we will be able to satisfy the constraint.
return true;
}
« no previous file with comments | « CHANGELOG.md ('k') | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698