Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2343853002: Upstream helper script to build Chromium on iOS and update instructions. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream helper script to build Chromium on iOS and update instructions. Upstream some scripts used to simplify the setup of a new Chromium on iOS checkout and update the instruction to remove obsolete informations, and add recommendation to use the script. BUG=None Committed: https://crrev.com/7f4c25f2b5b8c745b254197282630dbcd7bfa755 Cr-Commit-Position: refs/heads/master@{#419422}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -98 lines) Patch
M docs/ios_build_instructions.md View 1 2 chunks +52 lines, -98 lines 0 comments Download
A ios/build/tools/convert_gn_xcodeproj.py View 1 chunk +214 lines, -0 lines 0 comments Download
A ios/build/tools/setup-gn.config View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/build/tools/setup-gn.py View 1 chunk +346 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
Please take a look.
4 years, 3 months ago (2016-09-15 13:47:34 UTC) #2
sdefresne
Ping?
4 years, 3 months ago (2016-09-19 08:20:06 UTC) #3
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/2343853002/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/2343853002/diff/1/docs/ios_build_instructions.md#newcode17 docs/ios_build_instructions.md:17: To checkout the source, use `fetch` command from ...
4 years, 3 months ago (2016-09-19 09:03:30 UTC) #4
sdefresne
On 2016/09/19 09:03:30, noyau wrote: > lgtm > > https://codereview.chromium.org/2343853002/diff/1/docs/ios_build_instructions.md > File docs/ios_build_instructions.md (right): > ...
4 years, 3 months ago (2016-09-19 09:43:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343853002/20001
4 years, 3 months ago (2016-09-19 09:48:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 09:56:24 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 09:58:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f4c25f2b5b8c745b254197282630dbcd7bfa755
Cr-Commit-Position: refs/heads/master@{#419422}

Powered by Google App Engine
This is Rietveld 408576698