Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2343833002:
Remove workaround from GN proto_library. (Closed)
DescriptionRemove workaround from GN proto_library.
Added support for script protobuf compiler plugins.
Removed |json_converter| option workaround.
BUG=637292
Committed: https://crrev.com/ec3645ef783be944a98beafd6c8b1858b4c39aeb
Cr-Commit-Position: refs/heads/master@{#419139}
Patch Set 1 #Patch Set 2 : deps #Patch Set 3 : nit #
Total comments: 4
Patch Set 4 : typo #
Messages
Total messages: 23 (16 generated)
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
kraynov@chromium.org changed reviewers: + wychen@chromium.org, xyzzyz@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
nice job, lgtm https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... File third_party/protobuf/proto_library.gni (right): https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... third_party/protobuf/proto_library.gni:47: # Path to plugin script. Mutual exclusive with |generator_plugin_label|. Mutually?
lgtm https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... File third_party/protobuf/proto_library.gni (right): https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... third_party/protobuf/proto_library.gni:52: # generator_plugin_suffix[es] (required if using a plugin) Nice touch!
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Waiting for trybots then land https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... File third_party/protobuf/proto_library.gni (right): https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... third_party/protobuf/proto_library.gni:47: # Path to plugin script. Mutual exclusive with |generator_plugin_label|. On 2016/09/15 18:09:01, xyzzyz wrote: > Mutually? Done. https://codereview.chromium.org/2343833002/diff/40001/third_party/protobuf/pr... third_party/protobuf/proto_library.gni:52: # generator_plugin_suffix[es] (required if using a plugin) On 2016/09/15 18:40:39, wychen wrote: > Nice touch! Acknowledged.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kraynov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xyzzyz@chromium.org, wychen@chromium.org Link to the patchset: https://codereview.chromium.org/2343833002/#ps60001 (title: "typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove workaround from GN proto_library. Added support for script protobuf compiler plugins. Removed |json_converter| option workaround. BUG=637292 ========== to ========== Remove workaround from GN proto_library. Added support for script protobuf compiler plugins. Removed |json_converter| option workaround. BUG=637292 Committed: https://crrev.com/ec3645ef783be944a98beafd6c8b1858b4c39aeb Cr-Commit-Position: refs/heads/master@{#419139} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ec3645ef783be944a98beafd6c8b1858b4c39aeb Cr-Commit-Position: refs/heads/master@{#419139} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
