Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: src/ic/s390/handler-compiler-s390.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ppc/ic-ppc.cc ('k') | src/ic/s390/ic-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 ExternalReference::Type type = ExternalReference::DIRECT_API_CALL; 303 ExternalReference::Type type = ExternalReference::DIRECT_API_CALL;
304 ExternalReference ref = ExternalReference(&fun, type, masm->isolate()); 304 ExternalReference ref = ExternalReference(&fun, type, masm->isolate());
305 __ mov(api_function_address, Operand(ref)); 305 __ mov(api_function_address, Operand(ref));
306 306
307 // Jump to stub. 307 // Jump to stub.
308 CallApiCallbackStub stub(isolate, is_store, call_data_undefined, 308 CallApiCallbackStub stub(isolate, is_store, call_data_undefined,
309 !optimization.is_constant_call()); 309 !optimization.is_constant_call());
310 __ TailCallStub(&stub); 310 __ TailCallStub(&stub);
311 } 311 }
312 312
313 static void StoreIC_PushArgs(MacroAssembler* masm) {
314 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(),
315 StoreDescriptor::ValueRegister(),
316 StoreWithVectorDescriptor::SlotRegister(),
317 StoreWithVectorDescriptor::VectorRegister());
318 }
319
320 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) {
321 StoreIC_PushArgs(masm);
322
323 // The slow case calls into the runtime to complete the store without causing
324 // an IC miss that would otherwise cause a transition to the generic stub.
325 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
326 }
327
328 #undef __ 313 #undef __
329 #define __ ACCESS_MASM(masm()) 314 #define __ ACCESS_MASM(masm())
330 315
331 void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label, 316 void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label,
332 Handle<Name> name) { 317 Handle<Name> name) {
333 if (!label->is_unused()) { 318 if (!label->is_unused()) {
334 __ bind(label); 319 __ bind(label);
335 __ mov(this->name(), Operand(name)); 320 __ mov(this->name(), Operand(name));
336 } 321 }
337 } 322 }
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 640
656 // Return the generated code. 641 // Return the generated code.
657 return GetCode(kind(), name); 642 return GetCode(kind(), name);
658 } 643 }
659 644
660 #undef __ 645 #undef __
661 } // namespace internal 646 } // namespace internal
662 } // namespace v8 647 } // namespace v8
663 648
664 #endif // V8_TARGET_ARCH_ARM 649 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/ppc/ic-ppc.cc ('k') | src/ic/s390/ic-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698