Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: src/ic/ppc/ic-ppc.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 StoreWithVectorDescriptor::VectorRegister()); 457 StoreWithVectorDescriptor::VectorRegister());
458 } 458 }
459 459
460 460
461 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 461 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
462 StoreIC_PushArgs(masm); 462 StoreIC_PushArgs(masm);
463 463
464 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 464 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
465 } 465 }
466 466
467 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
468 StoreIC_PushArgs(masm);
469
470 // The slow case calls into the runtime to complete the store without causing
471 // an IC miss that would otherwise cause a transition to the generic stub.
472 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
473 }
467 474
468 static void KeyedStoreGenerateMegamorphicHelper( 475 static void KeyedStoreGenerateMegamorphicHelper(
469 MacroAssembler* masm, Label* fast_object, Label* fast_double, Label* slow, 476 MacroAssembler* masm, Label* fast_object, Label* fast_double, Label* slow,
470 KeyedStoreCheckMap check_map, KeyedStoreIncrementLength increment_length, 477 KeyedStoreCheckMap check_map, KeyedStoreIncrementLength increment_length,
471 Register value, Register key, Register receiver, Register receiver_map, 478 Register value, Register key, Register receiver, Register receiver_map,
472 Register elements_map, Register elements) { 479 Register elements_map, Register elements) {
473 Label transition_smi_elements; 480 Label transition_smi_elements;
474 Label finish_object_store, non_double_value, transition_double_elements; 481 Label finish_object_store, non_double_value, transition_double_elements;
475 Label fast_double_without_map_check; 482 Label fast_double_without_map_check;
476 483
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
863 patcher.EmitCondition(ne); 870 patcher.EmitCondition(ne);
864 } else { 871 } else {
865 DCHECK(Assembler::GetCondition(branch_instr) == ne); 872 DCHECK(Assembler::GetCondition(branch_instr) == ne);
866 patcher.EmitCondition(eq); 873 patcher.EmitCondition(eq);
867 } 874 }
868 } 875 }
869 } // namespace internal 876 } // namespace internal
870 } // namespace v8 877 } // namespace v8
871 878
872 #endif // V8_TARGET_ARCH_PPC 879 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698