Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/mips64/ic-mips64.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/ppc/handler-compiler-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 709 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 StoreWithVectorDescriptor::VectorRegister()); 720 StoreWithVectorDescriptor::VectorRegister());
721 } 721 }
722 722
723 723
724 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 724 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
725 StoreIC_PushArgs(masm); 725 StoreIC_PushArgs(masm);
726 726
727 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 727 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
728 } 728 }
729 729
730 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
731 StoreIC_PushArgs(masm);
732
733 // The slow case calls into the runtime to complete the store without causing
734 // an IC miss that would otherwise cause a transition to the generic stub.
735 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
736 }
737
730 void StoreIC::GenerateMiss(MacroAssembler* masm) { 738 void StoreIC::GenerateMiss(MacroAssembler* masm) {
731 StoreIC_PushArgs(masm); 739 StoreIC_PushArgs(masm);
732 740
733 // Perform tail call to the entry. 741 // Perform tail call to the entry.
734 __ TailCallRuntime(Runtime::kStoreIC_Miss); 742 __ TailCallRuntime(Runtime::kStoreIC_Miss);
735 } 743 }
736 744
737 745
738 void StoreIC::GenerateNormal(MacroAssembler* masm) { 746 void StoreIC::GenerateNormal(MacroAssembler* masm) {
739 Label miss; 747 Label miss;
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 break; 889 break;
882 default: 890 default:
883 UNIMPLEMENTED(); 891 UNIMPLEMENTED();
884 } 892 }
885 patcher.ChangeBranchCondition(branch_instr, opcode); 893 patcher.ChangeBranchCondition(branch_instr, opcode);
886 } 894 }
887 } // namespace internal 895 } // namespace internal
888 } // namespace v8 896 } // namespace v8
889 897
890 #endif // V8_TARGET_ARCH_MIPS64 898 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/ppc/handler-compiler-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698