Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 // the place to continue after deoptimization. 316 // the place to continue after deoptimization.
317 masm->isolate()->heap()->SetGetterStubDeoptPCOffset(masm->pc_offset()); 317 masm->isolate()->heap()->SetGetterStubDeoptPCOffset(masm->pc_offset());
318 } 318 }
319 319
320 // Restore context register. 320 // Restore context register.
321 __ Pop(cp); 321 __ Pop(cp);
322 } 322 }
323 __ Ret(); 323 __ Ret();
324 } 324 }
325 325
326
327 static void StoreIC_PushArgs(MacroAssembler* masm) {
328 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(),
329 StoreDescriptor::ValueRegister(),
330 StoreWithVectorDescriptor::SlotRegister(),
331 StoreWithVectorDescriptor::VectorRegister());
332 }
333
334
335 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) {
336 ASM_LOCATION("ElementHandlerCompiler::GenerateStoreSlow");
337 StoreIC_PushArgs(masm);
338
339 // The slow case calls into the runtime to complete the store without causing
340 // an IC miss that would otherwise cause a transition to the generic stub.
341 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
342 }
343
344
345 #undef __ 326 #undef __
346 #define __ ACCESS_MASM(masm()) 327 #define __ ACCESS_MASM(masm())
347 328
348 329
349 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 330 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
350 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) { 331 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
351 Label miss; 332 Label miss;
352 if (IC::ICUseVector(kind())) { 333 if (IC::ICUseVector(kind())) {
353 PushVectorAndSlot(); 334 PushVectorAndSlot();
354 } 335 }
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 // Return the generated code. 676 // Return the generated code.
696 return GetCode(kind(), name); 677 return GetCode(kind(), name);
697 } 678 }
698 679
699 680
700 #undef __ 681 #undef __
701 } // namespace internal 682 } // namespace internal
702 } // namespace v8 683 } // namespace v8
703 684
704 #endif // V8_TARGET_ARCH_IA32 685 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698