Remove outdated TODO in SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread().

Remove outdated TODO in SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread().

Now that SchedulerSequencedTaskRunner::RunsTasksOnCurrentThread()
returns true iff the current task is part of the
SchedulerSequencedTaskRunner's sequence, the TODO in
SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread() does
not apply anymore.

BUG=622400
Committed: https://crrev.com/c8f706ab3b7b9b0a10488e5144b843b2648c7c2f
Cr-Commit-Position: refs/heads/master@{#419152}

[fdoray, 2016-09-15 15:57:12]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2016-09-15 15:57:13]

PTAL

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
File base/threading/sequenced_worker_pool.cc (right):

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
base/threading/sequenced_worker_pool.cc:882: DCHECK(sequence_token.IsValid());
This is always called from PoolSequencedTaskRunner::RunsTasksOnCurrentThread
with a valid sequence token (hmm... unless the PoolSequencedTaskRunner was
created with an invalid SequenceToken, which doesn't seem like a valid thing to
do...)

[gab, 2016-09-15 16:37:27]

lgtm

[fdoray, 2016-09-15 16:42:44]

fdoray@chromium.org changed reviewers:
+ danakj@chromium.org

[fdoray, 2016-09-15 16:42:45]

danakj@: PTAL

[robliao, 2016-09-15 16:58:29]

lgtm

[danakj, 2016-09-15 18:31:09]

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
File base/threading/sequenced_worker_pool.cc (left):

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
base/threading/sequenced_worker_pool.cc:885: // TODO(gab): This currently only
verifies that the current thread is a
Isn't SequencedWorkerPool::Inner::RunsTasksOnCurrentThread still just making a
task runner and checking if it uses the current thread? I'm kinda confused

[fdoray, 2016-09-15 18:39:23]

PTAnL

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
File base/threading/sequenced_worker_pool.cc (left):

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
base/threading/sequenced_worker_pool.cc:885: // TODO(gab): This currently only
verifies that the current thread is a
On 2016/09/15 18:31:09, danakj wrote:
> Isn't SequencedWorkerPool::Inner::RunsTasksOnCurrentThread still just making a
> task runner and checking if it uses the current thread? I'm kinda confused

|sequenced_task_runner_map_| contains TaskScheduler TaskRunners. Line 892 calls
SchedulerSequencedTaskRunner::RunsTasksOnCurrentThread which does exactly what
we want (i.e. tell us if the current task is part of the the sequence associated
with |sequence_token|) since https://codereview.chromium.org/2340793002/

[danakj, 2016-09-15 18:41:26]

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
File base/threading/sequenced_worker_pool.cc (left):

https://codereview.chromium.org/2343803004/diff/1/base/threading/sequenced_wo...
base/threading/sequenced_worker_pool.cc:885: // TODO(gab): This currently only
verifies that the current thread is a
On 2016/09/15 18:39:23, fdoray wrote:
> On 2016/09/15 18:31:09, danakj wrote:
> > Isn't SequencedWorkerPool::Inner::RunsTasksOnCurrentThread still just making
a
> > task runner and checking if it uses the current thread? I'm kinda confused
> 
> |sequenced_task_runner_map_| contains TaskScheduler TaskRunners. Line 892
calls
> SchedulerSequencedTaskRunner::RunsTasksOnCurrentThread which does exactly what
> we want (i.e. tell us if the current task is part of the the sequence
associated
> with |sequence_token|) since https://codereview.chromium.org/2340793002/

Thanks for the context! LGTM

[fdoray, 2016-09-16 12:14:08]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:14:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:04:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-16 13:06:46]

Description was changed from

==========
Remove outdated TODO in
SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread().

Now that SchedulerSequencedTaskRunner::RunsTasksOnCurrentThread()
returns true iff the current task is part of the
SchedulerSequencedTaskRunner's sequence, the TODO in
SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread() does
not apply anymore.

BUG=622400
==========

to

==========
Remove outdated TODO in
SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread().

Now that SchedulerSequencedTaskRunner::RunsTasksOnCurrentThread()
returns true iff the current task is part of the
SchedulerSequencedTaskRunner's sequence, the TODO in
SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread() does
not apply anymore.

BUG=622400

Committed: https://crrev.com/c8f706ab3b7b9b0a10488e5144b843b2648c7c2f
Cr-Commit-Position: refs/heads/master@{#419152}
==========

[commit-bot: I haz the power, 2016-09-16 13:06:47]

Patchset 1 (id:??) landed as
https://crrev.com/c8f706ab3b7b9b0a10488e5144b843b2648c7c2f
Cr-Commit-Position: refs/heads/master@{#419152}