Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: ipc/ipc_channel_proxy.h

Issue 2343783003: Corrects mojom::RouteProvider registration in ChildThreadImpl (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/child_thread_impl.cc ('k') | ipc/ipc_channel_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_proxy.h
diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
index 14b5fe0a4d86240f5ccd96ac8a5b2a9b16fc3792..db3aeadb679b3cb11124e48317ec4ae07297c666 100644
--- a/ipc/ipc_channel_proxy.h
+++ b/ipc/ipc_channel_proxy.h
@@ -164,13 +164,17 @@ class IPC_EXPORT ChannelProxy : public Endpoint, public base::NonThreadSafe {
base::Callback<void(mojo::ScopedInterfaceEndpointHandle)>;
// Adds a generic associated interface factory to bind incoming interface
- // requests directly on the IO thread. MUST be called before Init().
+ // requests directly on the IO thread. MUST be called either before Init() or
+ // before the remote end of the Channel is able to send messages (e.g. before
+ // its process is launched.)
void AddGenericAssociatedInterfaceForIOThread(
const std::string& name,
const GenericAssociatedInterfaceFactory& factory);
// Adds a generic associated interface factory to bind incoming interface
- // requests on the ChannelProxy's thread. MUST be called before Init().
+ // requests on the ChannelProxy's thread. MUST be called before Init() or
+ // before the remote end of the Channel is able to send messages (e.g. before
+ // its process is launched.)
void AddGenericAssociatedInterface(
const std::string& name,
const GenericAssociatedInterfaceFactory& factory);
« no previous file with comments | « content/child/child_thread_impl.cc ('k') | ipc/ipc_channel_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698