Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2343783002: Make slot attributes unscopable (Closed)

Created:
4 years, 3 months ago by hayato
Modified:
4 years, 3 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make slot attributes unscopable PR for DOM Standard is: https://github.com/whatwg/dom/pull/329 Note: Blink's IDL uses [Unscopeable], instead of [Unscopable]. I have filed a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647133. Let me omit to add a layout test. It should be covered in WPT. BUG=643869 Committed: https://crrev.com/7db5d42ee2012ec61580506af7c0233fd049628d Cr-Commit-Position: refs/heads/master@{#418810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
hayato
PTAL
4 years, 3 months ago (2016-09-15 07:52:29 UTC) #9
kochi
lgtm
4 years, 3 months ago (2016-09-15 08:23:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343783002/1
4 years, 3 months ago (2016-09-15 08:49:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 08:53:16 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 08:54:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7db5d42ee2012ec61580506af7c0233fd049628d
Cr-Commit-Position: refs/heads/master@{#418810}

Powered by Google App Engine
This is Rietveld 408576698