[Offline pages] Updating the UpdateCallback in OPMStoreSQL

components/offline_pages/offline_page_item.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_item.h"
 
 #include "net/base/filename_util.h"
 
 namespace offline_pages {
 
@@ skipping 43 matching lines @@
       creation_time(creation_time),
       last_access_time(creation_time),
       access_count(0),
       flags(NO_FLAG) {}
 
 OfflinePageItem::OfflinePageItem(const OfflinePageItem& other) = default;
 
 OfflinePageItem::~OfflinePageItem() {
 }
 
+bool OfflinePageItem::operator==(const OfflinePageItem& other) const {
+  return url == other.url && offline_id == other.offline_id &&

[Dmitry Titov, 2016/09/20 20:43:37]

It'd be more human-readable if it was just a single column. A bit more lines but
less strain on eyes.

[fgorski, 2016/09/20 22:15:02]

Done. The problem is caused by "git cl format" and I absolutely agree with you.
I made a manual update at the end to prevent automatic formatting.

+         client_id == other.client_id && file_path == other.file_path &&
+         creation_time == other.creation_time &&
+         last_access_time == other.last_access_time &&
+         expiration_time == other.expiration_time &&
+         access_count == other.access_count && title == other.title &&
+         flags == other.flags;
+}
+
 GURL OfflinePageItem::GetOfflineURL() const {
   return net::FilePathToFileURL(file_path);
 }
 
 bool OfflinePageItem::IsExpired() const {
   return creation_time < expiration_time;
 }
 
 }  // namespace offline_pages