[Offline pages] Updating the UpdateCallback in OPMStoreSQL

components/offline_pages/offline_page_metadata_store.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_METADATA_STORE_H_
 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_METADATA_STORE_H_
 
 #include <stdint.h>
 
+#include <map>
 #include <vector>
 
 #include "base/callback.h"
 
 class GURL;
 
 namespace offline_pages {
 
 struct OfflinePageItem;
 
@@ skipping 30 matching lines @@
   enum ItemActionStatus {
     SUCCESS,
     ALREADY_EXISTS,
     DOESNT_EXIST,
     STORE_ERROR,
   };
 
   typedef base::Callback<void(LoadStatus, const std::vector<OfflinePageItem>&)>
       LoadCallback;
   typedef base::Callback<void(ItemActionStatus)> AddCallback;
-  typedef base::Callback<void(bool)> UpdateCallback;
+  typedef base::Callback<void(const std::map<int64_t, ItemActionStatus>&,

[dougarnett, 2016/09/15 19:57:24]

perhaps in the future, if we never end up using SUCCESS status code,
ItemActionStatus could become FailureStatus or similar and then this typedef
would be a bit more self documenting.

[dougarnett, 2016/09/15 19:57:24]

nit - seems like successful collection should come first and then failure
collections (but realize this may be easier iteration to keep same order).

[fgorski, 2016/09/19 23:24:29]

Done.(Callback redesigned in patch 1)

[fgorski, 2016/09/19 23:24:29]

Done. (Callback redesigned in patch 1)

+                              const std::vector<OfflinePageItem>&)>
+      UpdateCallback;
   typedef base::Callback<void(bool)> ResetCallback;
 
   OfflinePageMetadataStore();
   virtual ~OfflinePageMetadataStore();
 
   // Get all of the offline pages from the store.
   virtual void GetOfflinePages(const LoadCallback& callback) = 0;
 
   // Asynchronously adds an offline page item metadata to the store.
   virtual void AddOfflinePage(const OfflinePageItem& offline_page,
@@ skipping 11 matching lines @@
   // Resets the store.
   virtual void Reset(const ResetCallback& callback) = 0;
 
   // Gets the store state.
   virtual StoreState state() const = 0;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_METADATA_STORE_H_