Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: src/inspector/V8HeapProfilerAgentImpl.cc

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: more fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/V8HeapProfilerAgentImpl.cc
diff --git a/src/inspector/V8HeapProfilerAgentImpl.cc b/src/inspector/V8HeapProfilerAgentImpl.cc
index 3cc7b2a7df51b1de920b8ca8acb5574d2d8dd654..bd09dfb492697f9201aa134e5420710c65703e4b 100644
--- a/src/inspector/V8HeapProfilerAgentImpl.cc
+++ b/src/inspector/V8HeapProfilerAgentImpl.cc
@@ -30,7 +30,7 @@ static const char samplingHeapProfilerInterval[] =
class HeapSnapshotProgress final : public v8::ActivityControl {
public:
- HeapSnapshotProgress(protocol::HeapProfiler::Frontend* frontend)
+ explicit HeapSnapshotProgress(protocol::HeapProfiler::Frontend* frontend)
: m_frontend(frontend) {}
ControlOption ReportProgressValue(int done, int total) override {
m_frontend->reportHeapSnapshotProgress(done, total,
@@ -78,7 +78,7 @@ class GlobalObjectNameResolver final
class HeapSnapshotOutputStream final : public v8::OutputStream {
public:
- HeapSnapshotOutputStream(protocol::HeapProfiler::Frontend* frontend)
+ explicit HeapSnapshotOutputStream(protocol::HeapProfiler::Frontend* frontend)
: m_frontend(frontend) {}
void EndOfStream() override {}
int GetChunkSize() override { return 102400; }
@@ -113,7 +113,7 @@ class InspectableHeapObject final : public V8InspectorSession::Inspectable {
class HeapStatsStream final : public v8::OutputStream {
public:
- HeapStatsStream(protocol::HeapProfiler::Frontend* frontend)
+ explicit HeapStatsStream(protocol::HeapProfiler::Frontend* frontend)
: m_frontend(frontend) {}
void EndOfStream() override {}

Powered by Google App Engine
This is Rietveld 408576698