src/inspector/V8ConsoleMessage.cc - Issue 2343733002: [inspector] enabled presubmit for inspector sub folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/V8ConsoleMessage.cc

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)

Patch Set: more fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/V8ConsoleMessage.cc

diff --git a/src/inspector/V8ConsoleMessage.cc b/src/inspector/V8ConsoleMessage.cc

index 606c7fd1f64b192f3f1a0b4a17cb291c91f08229..03373ed07d296e559d9166473d68835b2fddcae6 100644

--- a/src/inspector/V8ConsoleMessage.cc

+++ b/src/inspector/V8ConsoleMessage.cc

@@ -75,7 +75,7 @@ class V8ValueStringBuilder {

IgnoreUndefined = 1 << 1,

};

- V8ValueStringBuilder(v8::Isolate* isolate)

+ explicit V8ValueStringBuilder(v8::Isolate* isolate)

: m_arrayLimit(maxArrayItemsLimit),

m_isolate(isolate),

m_tryCatch(isolate) {}