Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: src/inspector/String16.h

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: more fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/String16.h
diff --git a/src/inspector/String16.h b/src/inspector/String16.h
index 7fd367bb4d24b63f9d15835faee14188cace11b7..63e55ad9cc00836bb00af7c0b6c6c2f354f2a69b 100644
--- a/src/inspector/String16.h
+++ b/src/inspector/String16.h
@@ -23,8 +23,8 @@ class String16 {
String16() {}
String16(const String16& other) : m_impl(other.m_impl) {}
String16(const UChar* characters, size_t size) : m_impl(characters, size) {}
- String16(const UChar* characters) : m_impl(characters) {}
- String16(const char* characters)
+ explicit String16(const UChar* characters) : m_impl(characters) {}
dgozman 2016/09/14 23:56:47 Let's do the same nolint here.
kozy 2016/09/24 01:35:55 Done.
+ String16(const char* characters) // NOLINT(runtime/explicit)
: String16(characters, std::strlen(characters)) {}
String16(const char* characters, size_t size) {
m_impl.resize(size);

Powered by Google App Engine
This is Rietveld 408576698