Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 23437042: Even more GM:lumamode rebaselines. (Closed)

Created:
7 years, 3 months ago by f(malita)
Modified:
7 years, 3 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Even more GM:lumamode rebaselines. TBR=epoger Committed: https://code.google.com/p/skia/source/detail?r=11344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 3 months ago (2013-09-18 13:22:43 UTC) #1
f(malita)
7 years, 3 months ago (2013-09-18 13:24:16 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-18 13:24:23 UTC) #3
f(malita)
Committed patchset #1 manually as r11344.
7 years, 3 months ago (2013-09-18 13:33:15 UTC) #4
epoger
7 years, 3 months ago (2013-09-18 13:46:56 UTC) #5
Message was sent while issue was closed.
LGTM

I guess it just took a long time for these builders to complete generating the
new GM results?  Yikes.  I have to get them faster, as per
https://code.google.com/p/skia/issues/detail?id=1566 ('GenerateGMs takes way too
long on the bots')

Powered by Google App Engine
This is Rietveld 408576698