Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2343703003: Revert of Bundle common arguments to GrGradientEffect creation (Closed)

Created:
4 years, 3 months ago by djsollen
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Bundle common arguments to GrGradientEffect creation (patchset #2 id:20001 of https://codereview.chromium.org/2332213007/ ) Reason for revert: This seems to be causing the autoroll into Chromium to fail. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/69618/steps/compile/logs/stdio Original issue's description: > Bundle common arguments to GrGradientEffect creation > > I'm going to be adding more (to deal with color spaces), so trying to fix > this before it gets out of control. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007 > > Committed: https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/14e7a602d0cae354417ea963940b092d298adf4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -92 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 5 chunks +12 lines, -11 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +4 lines, -17 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 3 chunks +12 lines, -6 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 chunks +12 lines, -6 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 12 chunks +74 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
djsollen
Created Revert of Bundle common arguments to GrGradientEffect creation
4 years, 3 months ago (2016-09-15 02:57:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343703003/1
4 years, 3 months ago (2016-09-15 02:57:54 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 02:58:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/14e7a602d0cae354417ea963940b092d298adf4d

Powered by Google App Engine
This is Rietveld 408576698