Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/common/event_filtering_info.cc

Issue 23437015: Initial chrome.mdns API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable test for WinDbg Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/event_filtering_info.h ('k') | extensions/common/event_matcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/event_filtering_info.cc
diff --git a/extensions/common/event_filtering_info.cc b/extensions/common/event_filtering_info.cc
index 29566e891be26381c766ab7208b7bdb3c0bbc93e..cc46f969160750c332cc725b79b3fb57ff5120de 100644
--- a/extensions/common/event_filtering_info.cc
+++ b/extensions/common/event_filtering_info.cc
@@ -38,11 +38,15 @@ scoped_ptr<base::Value> EventFilteringInfo::AsValue() const {
if (has_instance_id_)
result->SetInteger("instanceId", instance_id_);
+
+ if (!service_type_.empty())
+ result->SetString("serviceType", service_type_);
+
return result.PassAs<base::Value>();
}
bool EventFilteringInfo::IsEmpty() const {
- return !has_url_;
+ return !has_url_ && service_type_.empty();
}
} // namespace extensions
« no previous file with comments | « extensions/common/event_filtering_info.h ('k') | extensions/common/event_matcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698