Issue 23437004: [PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23437004: [PDF] Fix printing crashes caused by font streams that don't support getMemoryBase(). (Closed)

Created:
7 years, 3 months ago by vandebo (ex-Chrome)

Modified:
7 years, 3 months ago

Reviewers:
bungeman-skia, djsollen1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase(). An apparently recently change started putting web fonts into SkStream objects that don't support getMemoryBase(). This change uses writeStream to avoid needing to call getMemoryBase(). BUG=chromium:274440 R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=10928

Patch Set 1 #

Patch Set 2 : Add comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	src/pdf/SkPDFStream.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/pdf/SkPDFStream.cpp	View		4 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

Another try of https://codereview.chromium.org/23414007/

7 years, 3 months ago (2013-08-26 20:53:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/23437004/4001

7 years, 3 months ago (2013-08-26 21:20:54 UTC) #4

commit-bot: I haz the power

Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildMost http://173.255.115.253:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=492

7 years, 3 months ago (2013-08-26 21:56:53 UTC) #5

vandebo (ex-Chrome)

7 years, 3 months ago (2013-08-26 22:52:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r10928 (presubmit successful).

Expand Messages | Collapse Messages