Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2343693002: Replace FX_UINT with unsigned int (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FX_UINT with unsigned int Remove the FX_UINT typedef and update to use the actual unsigned int type. Committed: https://pdfium.googlesource.com/pdfium/+/72177dadac8f9765440b3aa01e2668f60a8b3f43

Patch Set 1 #

Patch Set 2 : Remove include #

Total comments: 4

Patch Set 3 : Rebase to master #

Patch Set 4 : Review feedback #

Total comments: 2

Patch Set 5 : Remove #s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -145 lines) Patch
M fpdfsdk/cpdfsdk_document.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_environment.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 2 3 4 3 chunks +14 lines, -6 lines 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.h View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 1 2 3 3 chunks +18 lines, -16 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 2 3 15 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.h View 1 2 3 2 chunks +21 lines, -19 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 1 2 3 18 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.h View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_document.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_environment.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_pageview.h View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/resource.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/resource.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-14 19:57:49 UTC) #6
Tom Sepez
https://codereview.chromium.org/2343693002/diff/20001/fpdfsdk/include/fsdk_define.h File fpdfsdk/include/fsdk_define.h (right): https://codereview.chromium.org/2343693002/diff/20001/fpdfsdk/include/fsdk_define.h#newcode23 fpdfsdk/include/fsdk_define.h:23: // Convert a #FX_ARGB to a #FX_COLORREF. nit: can ...
4 years, 3 months ago (2016-09-15 16:42:16 UTC) #9
dsinclair
https://codereview.chromium.org/2343693002/diff/20001/fpdfsdk/include/fsdk_define.h File fpdfsdk/include/fsdk_define.h (right): https://codereview.chromium.org/2343693002/diff/20001/fpdfsdk/include/fsdk_define.h#newcode23 fpdfsdk/include/fsdk_define.h:23: // Convert a #FX_ARGB to a #FX_COLORREF. On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 17:38:32 UTC) #10
Tom Sepez
So much better. LGTM. https://codereview.chromium.org/2343693002/diff/60001/fpdfsdk/cpdfsdk_widget.cpp File fpdfsdk/cpdfsdk_widget.cpp (right): https://codereview.chromium.org/2343693002/diff/60001/fpdfsdk/cpdfsdk_widget.cpp#newcode44 fpdfsdk/cpdfsdk_widget.cpp:44: // Convert a #FX_ARGB to ...
4 years, 3 months ago (2016-09-15 17:41:21 UTC) #11
dsinclair
https://codereview.chromium.org/2343693002/diff/60001/fpdfsdk/cpdfsdk_widget.cpp File fpdfsdk/cpdfsdk_widget.cpp (right): https://codereview.chromium.org/2343693002/diff/60001/fpdfsdk/cpdfsdk_widget.cpp#newcode44 fpdfsdk/cpdfsdk_widget.cpp:44: // Convert a #FX_ARGB to a #FX_COLORREF. On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 17:45:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343693002/80001
4 years, 3 months ago (2016-09-15 17:46:02 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 19:07:27 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/72177dadac8f9765440b3aa01e2668f60a8b...

Powered by Google App Engine
This is Rietveld 408576698