Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2343683002: Workaround for scroll anchoring issue with AutoScrollExtensionSettingsWebUITest. (Closed)

Created:
4 years, 3 months ago by skobes
Modified:
4 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, ymalik, ojan, Finnur
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround for scroll anchoring issue with AutoScrollExtensionSettingsWebUITest. BUG=646977 Committed: https://crrev.com/101eea619734b9b9362b5557f2999317ea743a0b Cr-Commit-Position: refs/heads/master@{#418680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 2 chunks +5 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
skobes
This unblocks http://crrev.com/2335363003.
4 years, 3 months ago (2016-09-14 19:47:48 UTC) #4
skobes
+rdevlin.cronin who is in a better timezone
4 years, 3 months ago (2016-09-14 21:17:27 UTC) #8
Devlin
lgtm
4 years, 3 months ago (2016-09-14 21:22:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343683002/1
4 years, 3 months ago (2016-09-14 21:23:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 21:30:10 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:32:04 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/101eea619734b9b9362b5557f2999317ea743a0b
Cr-Commit-Position: refs/heads/master@{#418680}

Powered by Google App Engine
This is Rietveld 408576698