third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2343673003: SVG root viewport clip in paint property tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2343673003: SVG root viewport clip in paint property tree (Closed)

Patch Set: - Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index 3c4014a6451f100731fc363f8e298b447f8d4da2..47e0f7cb5f95d9d4c1bb90c115e35ec5312b862c 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -343,7 +343,7 @@ void PaintPropertyTreeBuilder::updateOverflowClip(const LayoutObject& object, Pa

LayoutRect clipRect;

if (box.hasControlClip()) {

clipRect = box.controlClipRect(context.current.paintOffset);

- } else if (box.hasOverflowClip()) {

+ } else if (box.hasOverflowClip() || (box.isSVGRoot() && toLayoutSVGRoot(box).shouldApplyViewportClip())) {

clipRect = box.overflowClipRect(context.current.paintOffset);

} else {

if (ObjectPaintProperties* properties = object.getMutableForPainting().objectPaintProperties())