third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp - Issue 2343673003: SVG root viewport clip in paint property tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp

Issue 2343673003: SVG root viewport clip in paint property tree (Closed)

Patch Set: - Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp

index ae076ae899e7270515f5694955de6502371cf8dc..6bd94f965673a5bbac1225491686c0c47553857b 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp

@@ -48,7 +48,7 @@ TEST_F(LayoutSVGRootTest, OverflowRectMappingWithViewportClipAndBorder)

LayoutRect rect = SVGLayoutSupport::clippedOverflowRectForPaintInvalidation(*svgRect, *root);

// (80, 80, 100, 100) added by root's content rect offset from border rect, clipped by (10, 10, 200, 100).

- EXPECT_EQ(LayoutRect(90, 90, 100, 30), rect);

+ EXPECT_EQ(LayoutRect(90, 90, 100, 20), rect);

Xianzhu 2016/09/14 21:36:00 This is also because of the change in SVGLayoutSup

LayoutRect rootOverflowRect = static_cast<const LayoutObject*>(root)->localOverflowRectForPaintInvalidation();

// SVG root with overflow:hidden doesn't include overflow from children, just border box rect.