Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

Issue 2343623002: Add a warning whenever link preloads are not used (Closed)
Patch Set: Removed the counter, since it was not accurate Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
index 05646be376de3df3f056119a39d446eed5078488..25a9180e2096cb173e249c04d8b5aa4cc4dd3198 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
@@ -613,6 +613,14 @@ TEST_F(ResourceFetcherTest, LinkPreloadImageMultipleFetchersAndUse)
Platform::current()->getURLLoaderMockFactory()->serveAsynchronousRequests();
fetcher2->preloadStarted(secondResource);
+ // Link rel preload scanner
+ FetchRequest fetchRequestLinkPreloadScanner = FetchRequest(url, FetchInitiatorInfo());
+ fetchRequestLinkPreloadScanner.setLinkPreload(true);
+ Resource* linkPreloadScannerResource = fetcher->requestResource(fetchRequestLinkPreloadScanner, TestResourceFactory(Resource::Image));
+ EXPECT_EQ(resource, linkPreloadScannerResource);
+ EXPECT_TRUE(resource->isLinkPreload());
+ fetcher->preloadStarted(resource);
+
// Image preload scanner
FetchRequest fetchRequestPreloadScanner = FetchRequest(url, FetchInitiatorInfo());
Resource* imgPreloadScannerResource = fetcher->requestResource(fetchRequestPreloadScanner, TestResourceFactory(Resource::Image));
@@ -620,6 +628,13 @@ TEST_F(ResourceFetcherTest, LinkPreloadImageMultipleFetchersAndUse)
EXPECT_FALSE(resource->isLinkPreload());
fetcher->preloadStarted(resource);
+ // Image preload scanner on the second fetcher
+ FetchRequest fetchRequestPreloadScanner2 = FetchRequest(url, FetchInitiatorInfo());
+ Resource* imgPreloadScannerResource2 = fetcher2->requestResource(fetchRequestPreloadScanner2, TestResourceFactory(Resource::Image));
+ EXPECT_EQ(resource, imgPreloadScannerResource2);
+ EXPECT_FALSE(resource->isLinkPreload());
+ fetcher2->preloadStarted(resource);
+
// Image created by parser
FetchRequest fetchRequest = FetchRequest(url, FetchInitiatorInfo());
Resource* newResource = fetcher->requestResource(fetchRequest, TestResourceFactory(Resource::Image));
@@ -627,6 +642,12 @@ TEST_F(ResourceFetcherTest, LinkPreloadImageMultipleFetchersAndUse)
EXPECT_EQ(resource, newResource);
EXPECT_FALSE(resource->isLinkPreload());
+ // Image created by parser on the second fetcher
+ FetchRequest fetchRequest2 = FetchRequest(url, FetchInitiatorInfo());
+ Resource* newResource2 = fetcher2->requestResource(fetchRequest, TestResourceFactory(Resource::Image));
+ Persistent<MockResourceClient> client2 = new MockResourceClient(newResource2);
+ EXPECT_EQ(resource, newResource2);
+ EXPECT_FALSE(resource->isLinkPreload());
// DCL reached on first fetcher
EXPECT_TRUE(resource->isPreloaded());
fetcher->clearPreloads(ResourceFetcher::ClearSpeculativeMarkupPreloads);

Powered by Google App Engine
This is Rietveld 408576698