Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(14)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-unused.html
Issue
2343623002
:
Add a warning whenever link preloads are not used (Closed)
Patch Set: Added comment
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-unused.html
third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-unused-expected.txt
third_party/WebKit/Source/core/fetch/FetchContext.h
third_party/WebKit/Source/core/fetch/FetchContext.cpp
third_party/WebKit/Source/core/fetch/ResourceFetcher.h
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
third_party/WebKit/Source/core/frame/LocalDOMWindow.h
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
third_party/WebKit/Source/core/loader/FrameFetchContext.h
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-unused-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<script>
3
if (window.testRunner) {
4
testRunner.waitUntilDone();
5
testRunner.dumpAsText();
6
}
7
window.setTimeout(function() {
8
if (window.testRunner) {
9
testRunner.notifyDone();
10
}
11
}, 4000);
12
</script>
13
<link rel="preload" as="image" href="resources/nick.jpg">
14
<link rel="preload" as="image" href="resources/nick.jpg?name=value">
15
<img src="resources/nick.jpg">
16
This test verifies that unused preload resources (and only unused ones) issue a warning.
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-unused-expected.txt »
('j') |
no next file with comments »
Issue 2343623002: Add a warning whenever link preloads are not used (Closed)
Created 4 years, 3 months ago by Yoav Weiss
Modified 4 years ago
Reviewers: Nate Chapin, Charlie Harrison, dgozman
Base URL:
Comments: 27
This is Rietveld
408576698
Chromium Code Reviews
Issue 2343623002:
Add a warning whenever link preloads are not used (Closed)
