Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

Issue 2343623002: Add a warning whenever link preloads are not used (Closed)
Patch Set: Removed the counter, since it was not accurate Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef LinkPreloadResourceClients_h 5 #ifndef LinkPreloadResourceClients_h
6 #define LinkPreloadResourceClients_h 6 #define LinkPreloadResourceClients_h
7 7
8 #include "core/fetch/CSSStyleSheetResource.h" 8 #include "core/fetch/CSSStyleSheetResource.h"
9 #include "core/fetch/FontResource.h" 9 #include "core/fetch/FontResource.h"
10 #include "core/fetch/ImageResource.h" 10 #include "core/fetch/ImageResource.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 DEFINE_INLINE_VIRTUAL_TRACE() 62 DEFINE_INLINE_VIRTUAL_TRACE()
63 { 63 {
64 LinkPreloadResourceClient::trace(visitor); 64 LinkPreloadResourceClient::trace(visitor);
65 ResourceOwner<ScriptResource, ScriptResourceClient>::trace(visitor); 65 ResourceOwner<ScriptResource, ScriptResourceClient>::trace(visitor);
66 } 66 }
67 67
68 private: 68 private:
69 LinkPreloadScriptResourceClient(LinkLoader* loader, ScriptResource* resource ) 69 LinkPreloadScriptResourceClient(LinkLoader* loader, ScriptResource* resource )
70 : LinkPreloadResourceClient(loader) 70 : LinkPreloadResourceClient(loader)
71 { 71 {
72 setResource(resource); 72 setResource(resource, Resource::DontMarkAsReferenced);
Charlie Harrison 2016/09/20 12:15:19 side note: I'm glad this new enum is proving usefu
Yoav Weiss 2016/09/21 07:45:41 Very useful! :)
73 } 73 }
74 }; 74 };
75 75
76 class LinkPreloadStyleResourceClient: public LinkPreloadResourceClient, public R esourceOwner<CSSStyleSheetResource, StyleSheetResourceClient> { 76 class LinkPreloadStyleResourceClient: public LinkPreloadResourceClient, public R esourceOwner<CSSStyleSheetResource, StyleSheetResourceClient> {
77 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadStyleResourceClient); 77 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadStyleResourceClient);
78 public: 78 public:
79 static LinkPreloadStyleResourceClient* create(LinkLoader* loader, CSSStyleSh eetResource* resource) 79 static LinkPreloadStyleResourceClient* create(LinkLoader* loader, CSSStyleSh eetResource* resource)
80 { 80 {
81 return new LinkPreloadStyleResourceClient(loader, resource); 81 return new LinkPreloadStyleResourceClient(loader, resource);
82 } 82 }
(...skipping 12 matching lines...) Expand all
95 DEFINE_INLINE_VIRTUAL_TRACE() 95 DEFINE_INLINE_VIRTUAL_TRACE()
96 { 96 {
97 LinkPreloadResourceClient::trace(visitor); 97 LinkPreloadResourceClient::trace(visitor);
98 ResourceOwner<CSSStyleSheetResource, StyleSheetResourceClient>::trace(vi sitor); 98 ResourceOwner<CSSStyleSheetResource, StyleSheetResourceClient>::trace(vi sitor);
99 } 99 }
100 100
101 private: 101 private:
102 LinkPreloadStyleResourceClient(LinkLoader* loader, CSSStyleSheetResource* re source) 102 LinkPreloadStyleResourceClient(LinkLoader* loader, CSSStyleSheetResource* re source)
103 : LinkPreloadResourceClient(loader) 103 : LinkPreloadResourceClient(loader)
104 { 104 {
105 setResource(resource); 105 setResource(resource, Resource::DontMarkAsReferenced);
106 } 106 }
107 }; 107 };
108 108
109 class LinkPreloadImageResourceClient: public LinkPreloadResourceClient, public R esourceOwner<ImageResource> { 109 class LinkPreloadImageResourceClient: public LinkPreloadResourceClient, public R esourceOwner<ImageResource> {
110 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadImageResourceClient); 110 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadImageResourceClient);
111 public: 111 public:
112 static LinkPreloadImageResourceClient* create(LinkLoader* loader, ImageResou rce* resource) 112 static LinkPreloadImageResourceClient* create(LinkLoader* loader, ImageResou rce* resource)
113 { 113 {
114 return new LinkPreloadImageResourceClient(loader, resource); 114 return new LinkPreloadImageResourceClient(loader, resource);
115 } 115 }
(...skipping 12 matching lines...) Expand all
128 DEFINE_INLINE_VIRTUAL_TRACE() 128 DEFINE_INLINE_VIRTUAL_TRACE()
129 { 129 {
130 LinkPreloadResourceClient::trace(visitor); 130 LinkPreloadResourceClient::trace(visitor);
131 ResourceOwner<ImageResource>::trace(visitor); 131 ResourceOwner<ImageResource>::trace(visitor);
132 } 132 }
133 133
134 private: 134 private:
135 LinkPreloadImageResourceClient(LinkLoader* loader, ImageResource* resource) 135 LinkPreloadImageResourceClient(LinkLoader* loader, ImageResource* resource)
136 : LinkPreloadResourceClient(loader) 136 : LinkPreloadResourceClient(loader)
137 { 137 {
138 setResource(resource); 138 setResource(resource, Resource::DontMarkAsReferenced);
139 } 139 }
140 }; 140 };
141 141
142 class LinkPreloadFontResourceClient: public LinkPreloadResourceClient, public Re sourceOwner<FontResource, FontResourceClient> { 142 class LinkPreloadFontResourceClient: public LinkPreloadResourceClient, public Re sourceOwner<FontResource, FontResourceClient> {
143 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadFontResourceClient); 143 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadFontResourceClient);
144 public: 144 public:
145 static LinkPreloadFontResourceClient* create(LinkLoader* loader, FontResourc e* resource) 145 static LinkPreloadFontResourceClient* create(LinkLoader* loader, FontResourc e* resource)
146 { 146 {
147 return new LinkPreloadFontResourceClient(loader, resource); 147 return new LinkPreloadFontResourceClient(loader, resource);
148 } 148 }
(...skipping 12 matching lines...) Expand all
161 DEFINE_INLINE_VIRTUAL_TRACE() 161 DEFINE_INLINE_VIRTUAL_TRACE()
162 { 162 {
163 LinkPreloadResourceClient::trace(visitor); 163 LinkPreloadResourceClient::trace(visitor);
164 ResourceOwner<FontResource, FontResourceClient>::trace(visitor); 164 ResourceOwner<FontResource, FontResourceClient>::trace(visitor);
165 } 165 }
166 166
167 private: 167 private:
168 LinkPreloadFontResourceClient(LinkLoader* loader, FontResource* resource) 168 LinkPreloadFontResourceClient(LinkLoader* loader, FontResource* resource)
169 : LinkPreloadResourceClient(loader) 169 : LinkPreloadResourceClient(loader)
170 { 170 {
171 setResource(resource); 171 setResource(resource, Resource::DontMarkAsReferenced);
172 } 172 }
173 }; 173 };
174 174
175 class LinkPreloadRawResourceClient: public LinkPreloadResourceClient, public Res ourceOwner<RawResource, RawResourceClient> { 175 class LinkPreloadRawResourceClient: public LinkPreloadResourceClient, public Res ourceOwner<RawResource, RawResourceClient> {
176 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadRawResourceClient); 176 USING_GARBAGE_COLLECTED_MIXIN(LinkPreloadRawResourceClient);
177 public: 177 public:
178 static LinkPreloadRawResourceClient* create(LinkLoader* loader, RawResource* resource) 178 static LinkPreloadRawResourceClient* create(LinkLoader* loader, RawResource* resource)
179 { 179 {
180 return new LinkPreloadRawResourceClient(loader, resource); 180 return new LinkPreloadRawResourceClient(loader, resource);
181 } 181 }
(...skipping 12 matching lines...) Expand all
194 DEFINE_INLINE_VIRTUAL_TRACE() 194 DEFINE_INLINE_VIRTUAL_TRACE()
195 { 195 {
196 LinkPreloadResourceClient::trace(visitor); 196 LinkPreloadResourceClient::trace(visitor);
197 ResourceOwner<RawResource, RawResourceClient>::trace(visitor); 197 ResourceOwner<RawResource, RawResourceClient>::trace(visitor);
198 } 198 }
199 199
200 private: 200 private:
201 LinkPreloadRawResourceClient(LinkLoader* loader, RawResource* resource) 201 LinkPreloadRawResourceClient(LinkLoader* loader, RawResource* resource)
202 : LinkPreloadResourceClient(loader) 202 : LinkPreloadResourceClient(loader)
203 { 203 {
204 setResource(resource); 204 setResource(resource, Resource::DontMarkAsReferenced);
205 } 205 }
206 }; 206 };
207 207
208 } // namespace blink 208 } // namespace blink
209 209
210 #endif // LinkPreloadResourceClients_h 210 #endif // LinkPreloadResourceClients_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698