Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3605)

Unified Diff: ash/common/system/tray_accessibility.h

Issue 2343603003: [Chrome OS MD] Implement accessibility detailed view for the MD Ash system menu (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray_accessibility.h
diff --git a/ash/common/system/tray_accessibility.h b/ash/common/system/tray_accessibility.h
index 1c280e317a957554a19e5b9348fcde0a22812e23..8e4a3158f14e397f5efd12f2b59db5d415e4faa3 100644
--- a/ash/common/system/tray_accessibility.h
+++ b/ash/common/system/tray_accessibility.h
@@ -21,6 +21,10 @@ namespace chromeos {
class TrayAccessibilityTest;
}
+namespace gfx {
+struct VectorIcon;
+}
+
namespace views {
class Button;
class ImageView;
@@ -51,6 +55,9 @@ class AccessibilityPopupView : public TrayNotificationView {
class AccessibilityDetailedView : public TrayDetailsView,
public ShellObserver {
public:
+ // Create the detailed view of accessibility tray. Note that the help option
tdanderson 2016/09/19 23:32:27 Generally a comment directly above a constructor s
yiyix 2016/09/21 17:10:48 I put the first sentence as a class description to
+ // row will be shown in non-MD version only and it will be integrated to the
+ // title row in MD.
AccessibilityDetailedView(SystemTrayItem* owner, LoginStatus login);
~AccessibilityDetailedView() override {}
@@ -66,9 +73,11 @@ class AccessibilityDetailedView : public TrayDetailsView,
// Add help entries.
void AppendHelpEntries();
+ // Helper function to create entries in the detailed accessibility view.
tdanderson 2016/09/19 23:32:27 nit: Maybe mention that the |icon| parameter is on
yiyix 2016/09/21 17:10:48 Done.
HoverHighlightView* AddScrollListItem(const base::string16& text,
bool highlight,
- bool checked);
+ bool checked,
+ const gfx::VectorIcon& icon);
views::View* spoken_feedback_view_;
views::View* high_contrast_view_;

Powered by Google App Engine
This is Rietveld 408576698