ui/gfx/vector_icons/check_circle.icon - Issue 2343603003: [Chrome OS MD] Implement accessibility detailed view for the MD Ash system menu

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/vector_icons/check_circle.icon

Issue 2343603003: [Chrome OS MD] Implement accessibility detailed view for the MD Ash system menu (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 CIRCLE, 24, 24, 20,	5 CANVAS_DIMENSIONS, 40,
	tdanderson 2016/09/15 16:13:26 The appearance of the checkmark icon used by the p The appearance of the checkmark icon used by the palette tool will be improved by this change. However note that the throbber is also using VectorIconId::CHECK_CIRCLE, rendering it at 18dp. See the comment "This magic number matches the default diamater plus padding inherent in the checkmark SVG." - since you're now using a different SVG with a different pixel grid, you'll need to make sure that the checkmark in the throbber still looks good. (You can do this by building and running the views_examples_with_content_exe target; it looks like there is a throbber example you can use.) The solution may be to tweak the value of 18 used by the throbber, or it may be that we'll need to keep ui/gfx/vector_icons/check_circle.icon as-is and have a separate ash/resources/vector_icons/system_menu_check_circle.icon used by the system menu and palette tool. yiyix 2016/09/19 20:24:55 Done. Show quoted text On 2016/09/15 16:13:26, tdanderson wrote: > The appearance of the checkmark icon used by the palette tool will be improved > by this change. > > However note that the throbber is also using VectorIconId::CHECK_CIRCLE, > rendering it at 18dp. See the comment "This magic number matches the default > diamater plus padding inherent in the checkmark SVG." - since you're now using a > different SVG with a different pixel grid, you'll need to make sure that the > checkmark in the throbber still looks good. (You can do this by building and > running the views_examples_with_content_exe target; it looks like there is a > throbber example you can use.) > > The solution may be to tweak the value of 18 used by the throbber, or it may be > that we'll need to keep ui/gfx/vector_icons/check_circle.icon as-is and have a > separate ash/resources/vector_icons/system_menu_check_circle.icon used by the > system menu and palette tool. Done.
6 MOVE_TO, 20, 34,	6 MOVE_TO, 20, 4,

7 LINE_TO, 10, 24,	7 CUBIC_TO, 11.17f, 4, 4, 11.17f, 4, 20,

8 R_LINE_TO, 2.83f, -2.83f,	8 R_CUBIC_TO, 0, 8.83f, 7.17f, 16, 16, 16,

9 LINE_TO, 20, 28.34f,	9 R_CUBIC_TO, 8.83f, 0, 16, -7.17f, 16, -16,

10 R_LINE_TO, 15.17f, -15.17f,	10 CUBIC_TO_SHORTHAND, 28.83f, 4, 20, 4,

11 LINE_TO, 38, 16,	11 CLOSE,

12 LINE_TO, 20, 34,	12 R_MOVE_TO, -3.2f, 24,

	13 R_LINE_TO, -8, -8,

	14 R_LINE_TO, 2.26f, -2.26f,

	15 R_LINE_TO, 5.74f, 5.73f,

	16 R_LINE_TO, 12.14f, -12.14f,

	17 LINE_TO, 31.2f, 13.6f,

	18 LINE_TO, 16.8f, 28,

	19 CLOSE,

13 END	20 END

OLD	NEW

« chrome/browser/chromeos/system/tray_accessibility_browsertest.cc ('K') | « ui/gfx/vector_icons/BUILD.gn ('k') | ui/gfx/vector_icons/check_circle.1x.icon » ('j') | no next file with comments »